Skip to content

[flang] Disable test on Windows #94396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[flang] Disable test on Windows #94396

wants to merge 1 commit into from

Conversation

klausler
Copy link
Contributor

@klausler klausler commented Jun 4, 2024

flang/test/Semantics/call40.f90 is behaving weirdly on Windows, perhaps due to a percent sign in a message that shouldn't be interpreted as a formatting character. Disable the test for now so that CI isn't producing confusing errors.

flang/test/Semantics/call40.f90 is behaving weirdly on Windows,
perhaps due to a percent sign in a message that shouldn't be
interpreted as a formatting character.  Disable the test for now
so that CI isn't producing confusing errors.
@llvmbot llvmbot added flang Flang issues not falling into any other category flang:semantics labels Jun 4, 2024
@llvmbot
Copy link
Member

llvmbot commented Jun 4, 2024

@llvm/pr-subscribers-flang-semantics

Author: Peter Klausler (klausler)

Changes

flang/test/Semantics/call40.f90 is behaving weirdly on Windows, perhaps due to a percent sign in a message that shouldn't be interpreted as a formatting character. Disable the test for now so that CI isn't producing confusing errors.


Full diff: https://github.com/llvm/llvm-project/pull/94396.diff

1 Files Affected:

  • (modified) flang/test/Semantics/call40.f90 (+1)
diff --git a/flang/test/Semantics/call40.f90 b/flang/test/Semantics/call40.f90
index e240b5a432184..1a37ed5e2cfa4 100644
--- a/flang/test/Semantics/call40.f90
+++ b/flang/test/Semantics/call40.f90
@@ -1,4 +1,5 @@
 ! RUN: %python %S/test_errors.py %s %flang_fc1
+! XFAIL: system-windows
 ! %VAL en %REF legacy extension semantic tests.
 
 subroutine val_errors(array, string, polymorphic, derived)

@DavidSpickett
Copy link
Collaborator

From the CI:

Unexpectedly Passed Tests (1):
  Flang :: Semantics/call40.f90

If this test sometimes passes sometimes doesn't, it'll have to be marked unsupported instead.

@luporl
Copy link
Contributor

luporl commented Jun 5, 2024

From the CI:

Unexpectedly Passed Tests (1):
  Flang :: Semantics/call40.f90

If this test sometimes passes sometimes doesn't, it'll have to be marked unsupported instead.

Right, but after #94331, this test should always pass.

So it seems the CI failed because this PR already includes #94331, making the test unexpectedly pass.

@DavidSpickett
Copy link
Collaborator

Ok got it, so this PR is not needed now?

@luporl
Copy link
Contributor

luporl commented Jun 5, 2024

Ok got it, so this PR is not needed now?

Yes, unless this test starts failing again on Windows.

@klausler klausler deleted the fix branch June 13, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:semantics flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants