[VPlan] Add getSCEVExprForVPValue util, use to get trip count SCEV (NFC) #94464

fhahn · 2024-06-05T12:37:07Z

Add a new getSCEVExprForVPValue utility which can be used to get a SCEV expression for a VPValue. The initial implementation only returns SCEVs for live-in IR values (by constructing a SCEV based on the live-in IR value) and VPExpandSCEVRecipe. This is enough to serve its first use, getting a SCEV for a VPlan's trip count, but will be extended in the future.

It also removes createTripCountSCEV, as the new helper can be used to retrieve the SCEV from the VPlan.

Add an initial version of VPScalarEvolution, which can be used to return a SCEV expression for a VPValue. The initial implementation only returns SCEVs for live-in IR values (by constructing a SCEV based on the live-in IR value) and VPExpandSCEVRecipe. This is enough to serve its first use, getting a SCEV for a VPlan's trip count, but will be extended in the future.

llvmbot · 2024-06-05T12:37:40Z

@llvm/pr-subscribers-llvm-transforms

Author: Florian Hahn (fhahn)

Changes

Add an initial version of VPScalarEvolution, which can be used to return a SCEV expression for a VPValue. The initial implementation only returns SCEVs for live-in IR values (by constructing a SCEV based on the live-in IR value) and VPExpandSCEVRecipe. This is enough to serve its first use, getting a SCEV for a VPlan's trip count, but will be extended in the future.

Full diff: https://github.com/llvm/llvm-project/pull/94464.diff

5 Files Affected:

(modified) llvm/lib/Transforms/Vectorize/LoopVectorize.cpp (+3-2)
(modified) llvm/lib/Transforms/Vectorize/VPlan.h (-3)
(modified) llvm/lib/Transforms/Vectorize/VPlanAnalysis.cpp (+13)
(modified) llvm/lib/Transforms/Vectorize/VPlanAnalysis.h (+15)
(modified) llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp (+1-3)

diff --git a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
index c7c19ef456c7c..14197259a9f98 100644
--- a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
+++ b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
@@ -978,8 +978,9 @@ Value *getRuntimeVF(IRBuilderBase &B, Type *Ty, ElementCount VF) {
   return B.CreateElementCount(Ty, VF);
 }
 
-const SCEV *createTripCountSCEV(Type *IdxTy, PredicatedScalarEvolution &PSE,
-                                Loop *OrigLoop) {
+static const SCEV *createTripCountSCEV(Type *IdxTy,
+                                       PredicatedScalarEvolution &PSE,
+                                       Loop *OrigLoop) {
   const SCEV *BackedgeTakenCount = PSE.getBackedgeTakenCount();
   assert(!isa<SCEVCouldNotCompute>(BackedgeTakenCount) && "Invalid loop count");
 
diff --git a/llvm/lib/Transforms/Vectorize/VPlan.h b/llvm/lib/Transforms/Vectorize/VPlan.h
index 943edc3520869..de37262d2c3de 100644
--- a/llvm/lib/Transforms/Vectorize/VPlan.h
+++ b/llvm/lib/Transforms/Vectorize/VPlan.h
@@ -79,9 +79,6 @@ Value *getRuntimeVF(IRBuilderBase &B, Type *Ty, ElementCount VF);
 Value *createStepForVF(IRBuilderBase &B, Type *Ty, ElementCount VF,
                        int64_t Step);
 
-const SCEV *createTripCountSCEV(Type *IdxTy, PredicatedScalarEvolution &PSE,
-                                Loop *CurLoop = nullptr);
-
 /// A range of powers-of-2 vectorization factors with fixed start and
 /// adjustable end. The range includes start and excludes end, e.g.,:
 /// [1, 16) = {1, 2, 4, 8}
diff --git a/llvm/lib/Transforms/Vectorize/VPlanAnalysis.cpp b/llvm/lib/Transforms/Vectorize/VPlanAnalysis.cpp
index 90bbf2d5d99fa..e9f01c1a334e1 100644
--- a/llvm/lib/Transforms/Vectorize/VPlanAnalysis.cpp
+++ b/llvm/lib/Transforms/Vectorize/VPlanAnalysis.cpp
@@ -9,6 +9,7 @@
 #include "VPlanAnalysis.h"
 #include "VPlan.h"
 #include "llvm/ADT/TypeSwitch.h"
+#include "llvm/Analysis/ScalarEvolution.h"
 
 using namespace llvm;
 
@@ -265,3 +266,15 @@ Type *VPTypeAnalysis::inferScalarType(const VPValue *V) {
   CachedTypes[V] = ResultTy;
   return ResultTy;
 }
+
+const SCEV *VPScalarEvolution::getSCEV(VPValue *V) {
+  if (V->isLiveIn())
+    return SE.getSCEV(V->getLiveInIRValue());
+
+  // TODO: Support constructing SCEVs for more recipes as needed.
+  return TypeSwitch<const VPRecipeBase *, const SCEV *>(V->getDefiningRecipe())
+      .Case<VPExpandSCEVRecipe>(
+          [](const VPExpandSCEVRecipe *R) { return R->getSCEV(); })
+      .Default(
+          [this](const VPRecipeBase *) { return SE.getCouldNotCompute(); });
+}
diff --git a/llvm/lib/Transforms/Vectorize/VPlanAnalysis.h b/llvm/lib/Transforms/Vectorize/VPlanAnalysis.h
index 7d310b1b31b6f..9d549778092c9 100644
--- a/llvm/lib/Transforms/Vectorize/VPlanAnalysis.h
+++ b/llvm/lib/Transforms/Vectorize/VPlanAnalysis.h
@@ -23,6 +23,8 @@ class VPWidenIntOrFpInductionRecipe;
 class VPWidenMemoryRecipe;
 struct VPWidenSelectRecipe;
 class VPReplicateRecipe;
+class SCEV;
+class ScalarEvolution;
 class Type;
 
 /// An analysis for type-inference for VPValues.
@@ -61,6 +63,19 @@ class VPTypeAnalysis {
   LLVMContext &getContext() { return Ctx; }
 };
 
+/// A light wrapper over ScalarEvolution to construct SCEV expressions for
+/// VPValues and recipes.
+class VPScalarEvolution {
+  ScalarEvolution &SE;
+
+public:
+  VPScalarEvolution(ScalarEvolution &SE) : SE(SE) {}
+
+  /// Return the SCEV expression for \p V. Returns SCEVCouldNotCompute if no
+  /// SCEV expression could be constructed.
+  const SCEV *getSCEV(VPValue *V);
+};
+
 } // end namespace llvm
 
 #endif // LLVM_TRANSFORMS_VECTORIZE_VPLANANALYSIS_H
diff --git a/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp b/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
index ab3b5cf2b9dab..541246266e1d5 100644
--- a/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
+++ b/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
@@ -674,10 +674,8 @@ void VPlanTransforms::optimizeForVFAndUF(VPlan &Plan, ElementCount BestVF,
              m_BranchOnCond(m_Not(m_ActiveLaneMask(m_VPValue(), m_VPValue())))))
     return;
 
-  Type *IdxTy =
-      Plan.getCanonicalIV()->getStartValue()->getLiveInIRValue()->getType();
-  const SCEV *TripCount = createTripCountSCEV(IdxTy, PSE);
   ScalarEvolution &SE = *PSE.getSE();
+  const SCEV *TripCount = VPScalarEvolution(SE).getSCEV(Plan.getTripCount());
   ElementCount NumElements = BestVF.multiplyCoefficientBy(BestUF);
   const SCEV *C = SE.getElementCount(TripCount->getType(), NumElements);
   if (TripCount->isZero() ||

rengolin · 2024-06-06T14:04:07Z

This looks ok to me, but not yet clear how the new VPScalarEvolution class will be used inside VPlanAnalysis.

Will it just be a helper class? If so, why not a static method? If not, then how will it be composed across different VPlans and the analysis part? I don't have a strong opinion here, just trying to understand the direction.

fhahn · 2024-06-10T20:24:28Z

This looks ok to me, but not yet clear how the new VPScalarEvolution class will be used inside VPlanAnalysis.

Will it just be a helper class? If so, why not a static method? If not, then how will it be composed across different VPlans and the analysis part? I don't have a strong opinion here, just trying to understand the direction.

In the future, I am planning to extend it to support constructing SCEVs for any recipe (e.g. VPInstruction::Add -> SE.getAddExpr({getSCEV(VPOp) for VPOp : Recipe->operands()})).

Users are expected to be spread across new analyses and transforms. It could also be a single getSCEVForVPValue(VPValue *VPV, ScalarEvolution &SE) entry point instead of providing a class, which may be more convenient?

rengolin · 2024-06-11T07:40:58Z

Users are expected to be spread across new analyses and transforms. It could also be a single getSCEVForVPValue(VPValue *VPV, ScalarEvolution &SE) entry point instead of providing a class, which may be more convenient?

Right, with spread usage comes passing the helper classes around, unless they're part of some other existing object that already gets passed around, or is in the global context.

In an object, this could even be in the VPInstruction itself, where each different instruction implements its own thing and then you just call VPOp->getSCEV(). As a global context (either an actual static global struct or within some existing shared context struct), this would likely be a long switch/case for each op.

fhahn · 2024-06-28T17:11:31Z

I think at this point it is not yet clear if it is desirable to add a common interface to VPValue/VPRecipeBase to get corresponding SCEVs, or if it makes more sense to have more specific interfaces returning more targeted information required to make vectorization decisions. This is why I think a lightweight helper functions for constructing trivial SCEVs would be a good start. WDYT?

fhahn · 2024-07-08T08:31:58Z

ping :)

ayalz

Thinking of alternatives to consider for discussion.

ayalz · 2024-07-08T15:43:03Z

llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp

  ScalarEvolution &SE = *PSE.getSE();
+  const SCEV *TripCount = VPScalarEvolution(SE).getSCEV(Plan.getTripCount());


Suffice to have, in this case, as an alternative,

Suggested change

const SCEV *TripCount = VPScalarEvolution(SE).getSCEV(Plan.getTripCount());

VPValue *TripCountVPV = Plan.getTripCount();

auto *Expand = dyn_cast<VPExpandSCEVRecipe>(TripCountVPV);

const SCEV *TripCount = Expand ? Expand->getSCEV() : SE.getSCEV(TripCountVPV->getLiveInIRValue());

asserting TripCountVPV is either an Expand or a live-in?
Perhaps could be folded into Plan.getTripCountSCEV(SE), or have vputils::getSCEVExprForVPValue() complement vputils::getOrCreateVPValueForSCEVExpr().

Simplified by moving to a single function, but kept declaration and definition in VPAnalysis for now

fhahn · 2024-07-18T08:24:05Z

ping :)

ayalz · 2024-07-18T11:59:12Z

llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp

  ScalarEvolution &SE = *PSE.getSE();
+  const SCEV *TripCount =
+      vputils::getSCEVExprForVPValue(Plan.getTripCount(), SE);


BTW, independently - BOC below would better use an unconditional branch than BranchOnCond with true condition.

Yes, will also entail to remove the region and header phis.

ayalz · 2024-07-18T12:02:38Z

llvm/lib/Transforms/Vectorize/VPlanAnalysis.h

@@ -26,6 +26,8 @@ struct VPWidenSelectRecipe;
 class VPReplicateRecipe;
 class VPRecipeBase;
 class VPlan;
+class SCEV;
+class ScalarEvolution;


nit: better placed above between LLVMContext and VPValue, along with Type.

Moved to VPlanUtils.h

ayalz · 2024-07-18T20:13:51Z

llvm/lib/Transforms/Vectorize/VPlanAnalysis.h

+/// Return the SCEV expression for \p V. Returns SCEVCouldNotCompute if no
+/// SCEV expression could be constructed.
+const SCEV *getSCEVExprForVPValue(VPValue *V, ScalarEvolution &SE);


Does this more naturally belong to VPlan.h and VPlan.cpp, alongside other vputils functions, in particular the complementary vputils::getOrCreateVPValueForSCEVExpr()?

VPlan.h has grown quite a bit by now, so I think it would possibly make sense to split things up by functionality a bit (same for VPlan.cpp). it doesn't necessarily have to go into VPlanAnalysis.cpp but could be moved into a separate VPlanUtils.h as an alternative.

Ok, +1 to reorganize all vputils functions in files of their own.

Most of these would presumably promote to a type system of VPValues, or other refinements like introducing an extract-first-lane as only user to capture onlyFirstLaneUsed().

Moved to VPlanUtils.cpp

fhahn

Moved to VPlanUtils

fhahn · 2024-08-29T19:09:23Z

llvm/lib/Transforms/Vectorize/VPlanAnalysis.h

@@ -26,6 +26,8 @@ struct VPWidenSelectRecipe;
 class VPReplicateRecipe;
 class VPRecipeBase;
 class VPlan;
+class SCEV;
+class ScalarEvolution;


Moved to VPlanUtils.h

fhahn · 2024-08-29T19:09:33Z

llvm/lib/Transforms/Vectorize/VPlanAnalysis.h

+/// Return the SCEV expression for \p V. Returns SCEVCouldNotCompute if no
+/// SCEV expression could be constructed.
+const SCEV *getSCEVExprForVPValue(VPValue *V, ScalarEvolution &SE);


Moved to VPlanUtils.cpp

fhahn · 2024-08-29T19:10:02Z

llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp

  ScalarEvolution &SE = *PSE.getSE();
+  const SCEV *TripCount =
+      vputils::getSCEVExprForVPValue(Plan.getTripCount(), SE);


Yes, will also entail to remove the region and header phis.

fhahn · 2024-09-09T18:36:53Z

ping :)

fhahn · 2024-09-16T17:50:28Z

ping :)

ayalz

I'm fine with this, thanks, with various minor comments, if @rengolin is.

ayalz · 2024-09-16T06:07:55Z

llvm/lib/Transforms/Vectorize/VPlanUtils.cpp

+const SCEV *vputils::getSCEVExprForVPValue(VPValue *V, ScalarEvolution &SE) {
+  if (V->isLiveIn())
+    return SE.getSCEV(V->getLiveInIRValue());
+


This seems to work well for Values at VPlan's boundary: can complement live-ins with live-out/VPIRInstructions which could also simply retrieve SE.getSCEV() of the instruction they wrap; as follow-up, along with concrete use.

ayalz · 2024-09-16T15:43:27Z

llvm/lib/Transforms/Vectorize/VPlanAnalysis.h

@@ -67,6 +67,7 @@ class VPTypeAnalysis {
 // Collect a VPlan's ephemeral recipes (those used only by an assume).
 void collectEphemeralRecipesForVPlan(VPlan &Plan,
                                     DenseSet<VPRecipeBase *> &EphRecipes);
+


Suggested change

Removed, thanks!

ayalz · 2024-09-16T15:51:39Z

llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp

  ScalarEvolution &SE = *PSE.getSE();
+  const SCEV *TripCount =
+      vputils::getSCEVExprForVPValue(Plan.getTripCount(), SE);


Worth asserting that the SCEV returned could be computed?

Thanks, added assert.

ayalz · 2024-09-16T20:08:19Z

llvm/lib/Transforms/Vectorize/LoopVectorize.cpp

-                                Loop *OrigLoop) {
+static const SCEV *createTripCountSCEV(Type *IdxTy,
+                                       PredicatedScalarEvolution &PSE,
+                                       Loop *OrigLoop) {


Possibly here or as follow-up:

The call to createTripCountSCEV() in LVP::selectEpilogueVectorizationFactor() has available VPlans from which to retrieve a TripCount VPValue and call the new API instead of continuing to call createTripCountSCEV().

The other two calls to createTripCountSCEV() are inside calls to VPlan::createInitialVPlan(), setting its first parameter; should they be inlined into createInitialVPlan() itself instead?
Thereby retiring createTripCountSCEV altogether, leaving only vputils::getSCEVExprForVPValue(Plan.getTripCount(), SE) as the way to obtain the SCEV of a loop's trip count.

Thanks, updated the PR to also inline createTripCountSCEV.

ayalz · 2024-09-16T20:13:25Z

llvm/lib/Transforms/Vectorize/VPlanUtils.h

+
+/// Return the SCEV expression for \p V. Returns SCEVCouldNotCompute if no
+/// SCEV expression could be constructed.
+const SCEV *getSCEVExprForVPValue(VPValue *V, ScalarEvolution &SE);
+


This complements getOrCreateVPValueForSCEVExpr() above and should be placed next to it.
(Otherwise would have suffice to call it getSCEVFor() or getSCEV(), as it currently delegates to SE.getSCEV() or SCEVExpandRecioe.getSCEV(). Could even have getOrCreateSCEVExprForVPValue() more consistently, but getSCEV() may typically create them - in contrast to getExistingSCEV().)

Moved, thanks!

fhahn

Thanks, comments should addressed!

@rengolin WDYT about the latest version?

fhahn · 2024-09-17T09:30:30Z

llvm/lib/Transforms/Vectorize/LoopVectorize.cpp

-                                Loop *OrigLoop) {
+static const SCEV *createTripCountSCEV(Type *IdxTy,
+                                       PredicatedScalarEvolution &PSE,
+                                       Loop *OrigLoop) {


Thanks, updated the PR to also inline createTripCountSCEV.

fhahn · 2024-09-17T09:30:49Z

llvm/lib/Transforms/Vectorize/VPlanAnalysis.h

@@ -67,6 +67,7 @@ class VPTypeAnalysis {
 // Collect a VPlan's ephemeral recipes (those used only by an assume).
 void collectEphemeralRecipesForVPlan(VPlan &Plan,
                                     DenseSet<VPRecipeBase *> &EphRecipes);
+


Removed, thanks!

fhahn · 2024-09-17T09:31:34Z

llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp

  ScalarEvolution &SE = *PSE.getSE();
+  const SCEV *TripCount =
+      vputils::getSCEVExprForVPValue(Plan.getTripCount(), SE);


Thanks, added assert.

fhahn · 2024-09-17T09:31:54Z

llvm/lib/Transforms/Vectorize/VPlanUtils.cpp

+const SCEV *vputils::getSCEVExprForVPValue(VPValue *V, ScalarEvolution &SE) {
+  if (V->isLiveIn())
+    return SE.getSCEV(V->getLiveInIRValue());
+


fhahn · 2024-09-17T09:33:02Z

llvm/lib/Transforms/Vectorize/VPlanUtils.h

+
+/// Return the SCEV expression for \p V. Returns SCEVCouldNotCompute if no
+/// SCEV expression could be constructed.
+const SCEV *getSCEVExprForVPValue(VPValue *V, ScalarEvolution &SE);
+


Moved, thanks!

ayalz

Thanks for the additional cleanup, adding few final nits.

ayalz · 2024-09-18T07:51:18Z

llvm/lib/Transforms/Vectorize/VPlan.cpp

                                   bool RequiresScalarEpilogueCheck,
                                   bool TailFolded, Loop *TheLoop) {
  VPIRBasicBlock *Entry = createVPIRBasicBlockFor(TheLoop->getLoopPreheader());
  VPBasicBlock *VecPreheader = new VPBasicBlock("vector.ph");
  auto Plan = std::make_unique<VPlan>(Entry, VecPreheader);
-  Plan->TripCount =
-      vputils::getOrCreateVPValueForSCEVExpr(*Plan, TripCount, SE);
+  {


nit: keeping the inlined block seems a bit odd, worth unboxing, or adding a comment?

Done, thanks!

ayalz · 2024-09-18T07:53:12Z

llvm/lib/Transforms/Vectorize/VPlan.cpp

-          : Builder.createICmp(CmpInst::ICMP_EQ, Plan->getTripCount(),
-                               &Plan->getVectorTripCount(),
-                               ScalarLatchTerm->getDebugLoc(), "cmp.n");
+      TailFolded ? Plan->getOrAddLiveIn(ConstantInt::getTrue(


nit: if the inlined block is unboxed, this change can be avoided.

Undone, thanks!

ayalz · 2024-09-18T07:54:39Z

llvm/lib/Transforms/Vectorize/VPlan.h

@@ -3477,8 +3474,8 @@ class VPlan {
  /// middle VPBasicBlock. If a check is needed to guard executing the scalar
  /// epilogue loop, it will be added to the middle block, together with
  /// VPBasicBlocks for the scalar preheader and exit blocks.


nit: would be good to explain what IdxTy stands for, and/or use a more descriptive name.

Updated to InductionTy and documented, thanks!

…FC) (llvm#94464) Add a new getSCEVExprForVPValue utility which can be used to get a SCEV expression for a VPValue. The initial implementation only returns SCEVs for live-in IR values (by constructing a SCEV based on the live-in IR value) and VPExpandSCEVRecipe. This is enough to serve its first use, getting a SCEV for a VPlan's trip count, but will be extended in the future. It also removes createTripCountSCEV, as the new helper can be used to retrieve the SCEV from the VPlan. PR: llvm#94464

fhahn requested review from rengolin, ayalz and aniragil June 5, 2024 12:37

llvmbot added vectorizers llvm:transforms labels Jun 5, 2024

ayalz reviewed Jul 8, 2024

View reviewed changes

fhahn added 2 commits July 12, 2024 10:21

Merge remote-tracking branch 'origin/main' into vplan-scev

c777a3a

!fixup move logic to single getSCEVExprForVPValue function

d7d389e

ayalz reviewed Jul 18, 2024

View reviewed changes

fhahn mentioned this pull request Aug 27, 2024

VPlan: factor out VPlanUtils into its own file (NFC) #105857

Merged

fhahn added 2 commits August 29, 2024 18:29

Merge remote-tracking branch 'origin/main' into vplan-scev

4d0f112

!fixup move to VPlanUtils.cpp

9bc1413

fhahn commented Aug 29, 2024

View reviewed changes

Merge branch 'main' into vplan-scev

dbe22b4

ayalz reviewed Sep 16, 2024

View reviewed changes

fhahn added 2 commits September 17, 2024 10:09

Merge remote-tracking branch 'origin/main' into vplan-scev

8449f8f

!fixup address comments, thanks!

ca98f41

fhahn commented Sep 17, 2024

View reviewed changes

ayalz approved these changes Sep 18, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into vplan-scev

3f72966

!fixup address comments, thanks!

cc75e4a

fhahn changed the title ~~[VPlan] Add initial VPScalarEvolution, use to get trip count SCEV (NFC)~~ [VPlan] Add getSCEVExprForVPValue util, use to get trip count SCEV (NFC) Sep 18, 2024

fhahn merged commit 0d736e2 into llvm:main Sep 18, 2024
8 checks passed

fhahn deleted the vplan-scev branch September 18, 2024 13:42

		ScalarEvolution &SE = *PSE.getSE();
		const SCEV *TripCount = VPScalarEvolution(SE).getSCEV(Plan.getTripCount());

-  const SCEV *TripCount = VPScalarEvolution(SE).getSCEV(Plan.getTripCount());
+  VPValue *TripCountVPV = Plan.getTripCount();
+  auto *Expand = dyn_cast<VPExpandSCEVRecipe>(TripCountVPV);
+  const SCEV *TripCount = Expand ? Expand->getSCEV() : SE.getSCEV(TripCountVPV->getLiveInIRValue());

[VPlan] Add getSCEVExprForVPValue util, use to get trip count SCEV (NFC) #94464

[VPlan] Add getSCEVExprForVPValue util, use to get trip count SCEV (NFC) #94464

Uh oh!

Conversation

fhahn commented Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

llvmbot commented Jun 5, 2024

Uh oh!

rengolin commented Jun 6, 2024

Uh oh!

fhahn commented Jun 10, 2024

Uh oh!

rengolin commented Jun 11, 2024

Uh oh!

fhahn commented Jun 28, 2024

Uh oh!

fhahn commented Jul 8, 2024

Uh oh!

ayalz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fhahn commented Jul 18, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fhahn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fhahn commented Sep 9, 2024

Uh oh!

fhahn commented Sep 16, 2024

Uh oh!

ayalz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fhahn commented Jun 5, 2024 •

edited

Loading