Skip to content

[lldb/crashlog] Remove aarch64 requirement on crashlog tests #94553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2024
Merged

[lldb/crashlog] Remove aarch64 requirement on crashlog tests #94553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46eb924
[lldb/crashlog] Remove aarch64 requirement on crashlog tests
medismailben Jun 5, 2024
dd9c826
[lldb/crashlog] Make image loading in tests single-threaded
medismailben Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lldb/examples/python/crashlog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1814,6 +1814,9 @@ def SymbolicateCrashLogs(debugger, command_args, result, is_command):
)
)

if "NO_PARALLEL_IMG_LOADING" in os.environ:
options.no_parallel_image_loading = True

if options.version:
print(debugger.GetVersionString())
return
Expand Down
2 changes: 1 addition & 1 deletion lldb/test/Shell/ScriptInterpreter/Python/Crashlog/app_specific_backtrace_crashlog.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# REQUIRES: python, native && target-aarch64 && system-darwin
# REQUIRES: python, native && system-darwin

# RUN: mkdir -p %t.dir
# RUN: yaml2obj %S/Inputs/application_specific_info/asi.yaml > %t.dir/asi
Expand Down
2 changes: 1 addition & 1 deletion lldb/test/Shell/ScriptInterpreter/Python/Crashlog/interactive_crashlog_invalid_target.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# REQUIRES: python, native && target-aarch64 && system-darwin
# REQUIRES: python, native && system-darwin

# RUN: %lldb -o 'command script import lldb.macosx.crashlog' \
# RUN: -o 'crashlog -V' \
Expand Down
2 changes: 1 addition & 1 deletion lldb/test/Shell/ScriptInterpreter/Python/Crashlog/interactive_crashlog_json.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# REQUIRES: python, native && target-aarch64 && system-darwin
# REQUIRES: python, native && system-darwin

# RUN: mkdir -p %t.dir
# RUN: yaml2obj %S/Inputs/interactive_crashlog/multithread-test.yaml > %t.dir/multithread-test
Expand Down
2 changes: 1 addition & 1 deletion lldb/test/Shell/ScriptInterpreter/Python/Crashlog/interactive_crashlog_legacy.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# REQUIRES: python, native && target-aarch64 && system-darwin
# REQUIRES: python, native && system-darwin

# RUN: mkdir -p %t.dir
# RUN: yaml2obj %S/Inputs/interactive_crashlog/multithread-test.yaml > %t.dir/multithread-test
Expand Down
2 changes: 1 addition & 1 deletion lldb/test/Shell/ScriptInterpreter/Python/Crashlog/last_exception_backtrace_crashlog.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# REQUIRES: python, native && target-aarch64 && system-darwin
# REQUIRES: python, native && system-darwin

# RUN: mkdir -p %t.dir
# RUN: yaml2obj %S/Inputs/application_specific_info/asi.yaml > %t.dir/asi
Expand Down
3 changes: 3 additions & 0 deletions lldb/test/Shell/ScriptInterpreter/Python/Crashlog/lit.local.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,6 @@ if 'lldb-repro' in config.available_features:
config.unsupported = True

config.environment["LLDB_APPLE_DSYMFORUUID_EXECUTABLE"] = ""

# Temporary parallel image loading deadlock workaround
config.environment["NO_PARALLEL_IMG_LOADING"] = ""
2 changes: 1 addition & 1 deletion lldb/test/Shell/ScriptInterpreter/Python/Crashlog/skipped_status_interactive_crashlog.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# REQUIRES: python, native && target-aarch64 && system-darwin
# REQUIRES: python, native && system-darwin

# RUN: mkdir -p %t.dir
# RUN: yaml2obj %S/Inputs/interactive_crashlog/multithread-test.yaml > %t.dir/multithread-test
Expand Down
Loading