[clang-tidy] Remove redundant LINK_LIBS

[nikic]

clangAnalysis is already being pulled in via clang_target_link_libraries(). Also listing it in LINK_LIBS means that we'll link both against the static libraries and the shared libclang-cpp.so library if CLANG_LINK_CLANG_DYLIB is enabled, and waste time on unnecessary LTO.

[llvmbot]

@llvm/pr-subscribers-clang-tools-extra

@llvm/pr-subscribers-clang-tidy

Author: Nikita Popov (nikic)

Changes

clangAnalysis is already being pulled in via clang_target_link_libraries(). Also listing it in LINK_LIBS means that we'll link both against the static libraries and the shared libclang-cpp.so library if CLANG_LINK_CLANG_DYLIB is enabled, and waste time on unnecessary LTO.

---

Full diff: https://github.com/llvm/llvm-project/pull/94588.diff

1 Files Affected:

• (modified) clang-tools-extra/clang-tidy/misc/CMakeLists.txt (-1)

diff --git a/clang-tools-extra/clang-tidy/misc/CMakeLists.txt b/clang-tools-extra/clang-tidy/misc/CMakeLists.txt
index 35e29b9a7d136..36fcd8fc1b277 100644
--- a/clang-tools-extra/clang-tidy/misc/CMakeLists.txt
+++ b/clang-tools-extra/clang-tidy/misc/CMakeLists.txt
@@ -43,7 +43,6 @@ add_clang_library(clangTidyMiscModule
   UseAnonymousNamespaceCheck.cpp
 
   LINK_LIBS
-  clangAnalysis
   clangTidy
   clangTidyUtils
 

[JonasToth]

As you requested my review:

The original linking was done for the ExprMutAnalyzer used in 'misc-const-correctness'. If clang-tidy is builtin without static analyzer Support, you get linker failure.

If the ExprMutAnalyzer is moved (back) to clang-tidy, the issue is not existent. The original move request was from static analysis background where they might wanted to use the class as well.