[SPIRV] Fix warning in SPIRVMergeRegionExitTargets.cpp

[hekota]

Fix warning in SPIRVMergeRegionExitTargets.cpp about "non-void function does not return a value in all control paths" by changing assert to llvm_unreachable.

[llvmbot]

@llvm/pr-subscribers-backend-spir-v

Author: Helena Kotas (hekota)

Changes

Fix warning in SPIRVMergeRegionExitTargets.cpp about "non-void function does not return a value in all control paths" by changing assert to llvm_unreachable.

---

Full diff: https://github.com/llvm/llvm-project/pull/95283.diff

1 Files Affected:

• (modified) llvm/lib/Target/SPIRV/SPIRVMergeRegionExitTargets.cpp (+1-1)

diff --git a/llvm/lib/Target/SPIRV/SPIRVMergeRegionExitTargets.cpp b/llvm/lib/Target/SPIRV/SPIRVMergeRegionExitTargets.cpp
index 52354281cdd7e..0747dd1bbaf40 100644
--- a/llvm/lib/Target/SPIRV/SPIRVMergeRegionExitTargets.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVMergeRegionExitTargets.cpp
@@ -100,7 +100,7 @@ class SPIRVMergeRegionExitTargets : public FunctionPass {
     }
 
     // TODO: add support for switch cases.
-    assert(false && "Unhandled terminator type.");
+    llvm_unreachable("Unhandled terminator type.");
   }
 
   /// Replaces |BB|'s branch targets present in |ToReplace| with |NewTarget|.

[Keenuts]

Thanks!
How did you get this warning? (Don't have it on my local build)

[hekota]

I've seen it in my local build, this is my config:

cmake -G "Ninja" -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl -DCMAKE_LINKER=lld-link -DCMAKE_BUILD_TYPE=Debug -DLLVM_PARALLEL_COMPILE_JOBS=60 -DLLVM_PARALLEL_LINK_JOBS=4 -DCMAKE_WARN_DEPRECATED=FALSE -S C:\llvm-project\llvm -B C:\llvm-project\build\x64-Debug -C C:\llvm-project\clang\cmake\caches\HLSL.cmake

[Keenuts]

Thanks!