Skip to content

[OpenMP][libomp] Remove Perl in favor of Python #95307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

jpeyton52
Copy link
Contributor

  • Removes all Perl scripts and modules
  • Adds Python3 scripts which mimic the behavior of the Perl scripts
  • Removes Perl from CMake; Adds Python3 requirement to CMake
  • The check-instruction-set.pl script is Knights Corner specific. The script is removed and not replicated with a corresponding Python3 script.

Relevant Discourse:
https://discourse.llvm.org/t/error-compiling-clang-with-offloading-support/79223/4

Fixes: #62289

* Removes all Perl scripts and modules
* Adds Python3 scripts which mimic the behavior of the Perl scripts
* Removes Perl from CMake; Adds Python3 requirement to CMake
* The check-instruction-set.pl script is Knights Corner specific.
  The script is removed and not replicated with a corresponding Python3
  script.

Relevant Discourse:
https://discourse.llvm.org/t/error-compiling-clang-with-offloading-support/79223/4

Fixes: llvm#62289
@llvmbot llvmbot added the openmp:libomp OpenMP host runtime label Jun 12, 2024
Copy link

github-actions bot commented Jun 12, 2024

✅ With the latest revision this PR passed the Python code formatter.

@shiltian
Copy link
Contributor

Can you also add in the document that Python 3 is required to build libomp? Also, does it make sense not to enable i18 by default such that Python 3 would not become required dependence?

@jpeyton52
Copy link
Contributor Author

Where in the documentation do we want to note the requirement? Please note that Python3 is REQUIRED for LLVM development in general (https://github.com/llvm/llvm-project/blob/main/llvm/CMakeLists.txt#L915) and is not just there to enable lit testing.

We still need the scripts to generate the default English messages (no real i18n enabled) in kmp_i18n_id.inc and kmp_i18n_default.inc on all platforms and the *.def files on Windows.

Copy link
Contributor

We had a complaint in the past about that we didn't mention we need perl in the document (openmp/README.rst), but since now we are moving to Python and it is required by LLVM project, I guess it will be fine.

Copy link
Contributor

@shiltian shiltian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jhuber6 jhuber6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for addressing this.

@jpeyton52 jpeyton52 merged commit 88dae3d into llvm:main Jun 20, 2024
5 checks passed
AlexisPerry pushed a commit to llvm-project-tlp/llvm-project that referenced this pull request Jul 9, 2024
* Removes all Perl scripts and modules
* Adds Python3 scripts which mimic the behavior of the Perl scripts
* Removes Perl from CMake; Adds Python3 requirement to CMake
* The check-instruction-set.pl script is Knights Corner specific. The
script is removed and not replicated with a corresponding Python3
script.

Relevant Discourse:

https://discourse.llvm.org/t/error-compiling-clang-with-offloading-support/79223/4

Fixes: llvm#62289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomp OpenMP host runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OpenMP][Doc] perl is required to build openmp but not mentioned on docs
4 participants