[compiler-rt] Remove 'memprof_meminfoblock.h' from MEMPROF_HEADERS (NFC) #95334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 8306968 deleted file `compiler-rt/lib/memprof/memprof_meminfoblock.h`, but didn't remove it from MEMPROF_HEADERS in `compiler-rt/lib/memprof/CMakeLists.txt`. Remove unneeded leftover line in `compiler-rt/lib/memprof/CMakeLists.txt`. p.s. GH llvm#54777 reported a llvm14 build failure due to the existence of the leftover line, but I'm unable to reproduce the build failure with llvm19 trunk.
|
@llvm/pr-subscribers-pgo Author: Youngsuk Kim (JOE1994) ChangesCommit 8306968 deleted file Remove unneeded leftover line in p.s. Full diff: https://github.com/llvm/llvm-project/pull/95334.diff 1 Files Affected:
diff --git a/compiler-rt/lib/memprof/CMakeLists.txt b/compiler-rt/lib/memprof/CMakeLists.txt
index 3f55c2f5e075e..e6d99daca6ee7 100644
--- a/compiler-rt/lib/memprof/CMakeLists.txt
+++ b/compiler-rt/lib/memprof/CMakeLists.txt
@@ -37,7 +37,6 @@ SET(MEMPROF_HEADERS
memprof_interface_internal.h
memprof_internal.h
memprof_mapping.h
- memprof_meminfoblock.h
memprof_mibmap.h
memprof_rawprofile.h
memprof_stack.h
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 8306968 deleted file
compiler-rt/lib/memprof/memprof_meminfoblock.h, but didn't remove it from MEMPROF_HEADERS incompiler-rt/lib/memprof/CMakeLists.txt.Remove unneeded leftover line in
compiler-rt/lib/memprof/CMakeLists.txt.p.s.
GH #54777 reported a llvm14 build failure due to the existence of the leftover line, but I'm unable to reproduce the build failure with llvm19 trunk.