-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[CI] Update setup-python action to v5 for GHA #95414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
@llvm/pr-subscribers-github-workflow Author: Jannick Kremer (DeinAlptraum) ChangesWe currently receive a warning on all Github Actions workflows that use Full diff: https://github.com/llvm/llvm-project/pull/95414.diff 5 Files Affected:
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index d62485e2ebb66..800e929157353 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -100,7 +100,7 @@ jobs:
with:
fetch-depth: 1
- name: Setup Python env
- uses: actions/setup-python@v4
+ uses: actions/setup-python@v5
with:
python-version: '3.11'
cache: 'pip'
diff --git a/.github/workflows/llvm-project-tests.yml b/.github/workflows/llvm-project-tests.yml
index a52dd2db8035d..0a228c41f354e 100644
--- a/.github/workflows/llvm-project-tests.yml
+++ b/.github/workflows/llvm-project-tests.yml
@@ -77,7 +77,7 @@ jobs:
# lldb. Using this setup-python action to make 3.10 the default
# python fixes this.
- name: Setup Python
- uses: actions/setup-python@v4
+ uses: actions/setup-python@v5
with:
python-version: ${{ inputs.python_version }}
- name: Install Ninja
diff --git a/.github/workflows/pr-code-format.yml b/.github/workflows/pr-code-format.yml
index 983838858ba43..0061ea46f37ab 100644
--- a/.github/workflows/pr-code-format.yml
+++ b/.github/workflows/pr-code-format.yml
@@ -58,7 +58,7 @@ jobs:
clangformat: 18.1.1
- name: Setup Python env
- uses: actions/setup-python@v4
+ uses: actions/setup-python@v5
with:
python-version: '3.11'
cache: 'pip'
diff --git a/.github/workflows/release-documentation.yml b/.github/workflows/release-documentation.yml
index 64572906988ba..70e5f08b6f72e 100644
--- a/.github/workflows/release-documentation.yml
+++ b/.github/workflows/release-documentation.yml
@@ -37,7 +37,7 @@ jobs:
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Setup Python env
- uses: actions/setup-python@v4
+ uses: actions/setup-python@v5
with:
cache: 'pip'
cache-dependency-path: './llvm/docs/requirements.txt'
diff --git a/.github/workflows/release-doxygen.yml b/.github/workflows/release-doxygen.yml
index 12c14bea52f62..ef00a438ce7ac 100644
--- a/.github/workflows/release-doxygen.yml
+++ b/.github/workflows/release-doxygen.yml
@@ -39,7 +39,7 @@ jobs:
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Setup Python env
- uses: actions/setup-python@v4
+ uses: actions/setup-python@v5
with:
cache: 'pip'
cache-dependency-path: './llvm/docs/requirements.txt'
|
@boomanaiden154 @tstellar based on older PRs, I think you are the right people to review GHA stuff? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I'm assuming you just grepped for all v4 action uses in the repo (just want to confirm that we don't have any more lying around).
WWe should probably hash pin these at some point, but given they weren't before, probably something to do in a later patch.
Thanks!
Yup that's right, these are all occurences of |
@DeinAlptraum Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested Please check whether problems have been caused by your change specifically, as How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
We currently receive a warning on all Github Actions workflows that use `setup-python`, since they all use v4 of the action, which uses the deprecated Node.js 16. This PR upgrades the action in all places to v5, which uses Node.js 20 (see [setup-python release page](https://github.com/actions/setup-python/releases/tag/v5.0.0))
We currently receive a warning on all Github Actions workflows that use
setup-python
, since they all use v4 of the action, which uses the deprecated Node.js 16. This PR upgrades the action in all places to v5, which uses Node.js 20 (see setup-python release page)