[SDPatternMatch] Only match ISD::SIGN_EXTEND in m_SExt #95415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #95365 (comment)
The current implementation of
m_SExt
matches bothISD::SIGN_EXTEND
andISD::SIGN_EXTEND_INREG
. However, in cases where we specifically need to match onlyISD::SIGN_EXTEND
, such as in the SelectionDAG graph below, this can lead to issues and unintended combinations.