Skip to content

[KnownBits] Remove commonBits #95430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kazutakahirata
Copy link
Contributor

commonBits has been deprecated since:

commit d8229e2
Author: Jay Foad [email protected]
Date: Wed May 10 16:50:33 2023 +0100

commonBits has been deprecated since:

  commit d8229e2
  Author: Jay Foad <[email protected]>
  Date:   Wed May 10 16:50:33 2023 +0100
@llvmbot
Copy link
Member

llvmbot commented Jun 13, 2024

@llvm/pr-subscribers-llvm-support

Author: Kazu Hirata (kazutakahirata)

Changes

commonBits has been deprecated since:

commit d8229e2
Author: Jay Foad <[email protected]>
Date: Wed May 10 16:50:33 2023 +0100


Full diff: https://github.com/llvm/llvm-project/pull/95430.diff

1 Files Affected:

  • (modified) llvm/include/llvm/Support/KnownBits.h (-6)
diff --git a/llvm/include/llvm/Support/KnownBits.h b/llvm/include/llvm/Support/KnownBits.h
index c206bd77d5880..7ed3d525bd8fb 100644
--- a/llvm/include/llvm/Support/KnownBits.h
+++ b/llvm/include/llvm/Support/KnownBits.h
@@ -311,12 +311,6 @@ struct KnownBits {
     return KnownBits(Zero | RHS.Zero, One | RHS.One);
   }
 
-  /// Compute known bits common to LHS and RHS.
-  LLVM_DEPRECATED("use intersectWith instead", "intersectWith")
-  static KnownBits commonBits(const KnownBits &LHS, const KnownBits &RHS) {
-    return LHS.intersectWith(RHS);
-  }
-
   /// Return true if LHS and RHS have no common bits set.
   static bool haveNoCommonBitsSet(const KnownBits &LHS, const KnownBits &RHS) {
     return (LHS.Zero | RHS.Zero).isAllOnes();

Copy link
Contributor

@jayfoad jayfoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kazutakahirata kazutakahirata merged commit 890ab28 into llvm:main Jun 13, 2024
5 of 7 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_remove_KnownBits_commonBits branch June 13, 2024 16:32
EthanLuisMcDonough pushed a commit to EthanLuisMcDonough/llvm-project that referenced this pull request Aug 13, 2024
commonBits has been deprecated since:

  commit d8229e2
  Author: Jay Foad <[email protected]>
  Date:   Wed May 10 16:50:33 2023 +0100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants