Skip to content

[NFC][CGSCC] Remove RCWorklist from CGSCCUpdateResult #95448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2024
Merged

[NFC][CGSCC] Remove RCWorklist from CGSCCUpdateResult #95448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions llvm/include/llvm/Analysis/CGSCCPassManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,17 +230,6 @@ using ModuleAnalysisManagerCGSCCProxy =
/// Passes which do not change the call graph structure in any way can just
/// ignore this argument to their run method.
struct CGSCCUpdateResult {
/// Worklist of the RefSCCs queued for processing.
///
/// When a pass refines the graph and creates new RefSCCs or causes them to
/// have a different shape or set of component SCCs it should add the RefSCCs
/// to this worklist so that we visit them in the refined form.
///
/// This worklist is in reverse post-order, as we pop off the back in order
/// to observe RefSCCs in post-order. When adding RefSCCs, clients should add
/// them in reverse post-order.
SmallPriorityWorklist<LazyCallGraph::RefSCC *, 1> &RCWorklist;

/// Worklist of the SCCs queued for processing.
///
/// When a pass refines the graph and creates new SCCs or causes them to have
Expand Down
12 changes: 8 additions & 4 deletions llvm/lib/Analysis/CGSCCPassManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,14 @@ ModuleToPostOrderCGSCCPassAdaptor::run(Module &M, ModuleAnalysisManager &AM) {

SmallVector<Function *, 4> DeadFunctions;

CGSCCUpdateResult UR = {
RCWorklist, CWorklist, InvalidRefSCCSet,
InvalidSCCSet, nullptr, PreservedAnalyses::all(),
InlinedInternalEdges, DeadFunctions, {}};
CGSCCUpdateResult UR = {CWorklist,
InvalidRefSCCSet,
InvalidSCCSet,
nullptr,
PreservedAnalyses::all(),
InlinedInternalEdges,
DeadFunctions,
{}};

// Request PassInstrumentation from analysis manager, will use it to run
// instrumenting callbacks for the passes later.
Expand Down
Loading