[LLDB] Remove the redundent increment of 'properties' variable

[xgupta]

This is described in (N3) https://pvs-studio.com/en/blog/posts/cpp/1126/

Warning message -
V547 Expression 'properties ++ > 0' is always false. CommandObjectTarget.cpp:100

I could not understand it properly but the properties++ operation is performed twice when the target architecture is valid.
First increment seems unnecessary since it is always false '0>0'.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Shivam Gupta (xgupta)

Changes

This is described in (N3) https://pvs-studio.com/en/blog/posts/cpp/1126/ so caught by the PVS Studio analyzer. Warning message -
V547 Expression 'properties ++ > 0' is always false. CommandObjectTarget.cpp:100

I could not understand it properly but the properties++ operation is performed twice when the target architecture is valid.
First increment seems unnecessary since it is always false '0>0'.

---

Full diff: https://github.com/llvm/llvm-project/pull/95675.diff

1 Files Affected:

• (modified) lldb/source/Commands/CommandObjectTarget.cpp (+1-1)

diff --git a/lldb/source/Commands/CommandObjectTarget.cpp b/lldb/source/Commands/CommandObjectTarget.cpp
index ae6c6d5479a19..c3d4307267a1b 100644
--- a/lldb/source/Commands/CommandObjectTarget.cpp
+++ b/lldb/source/Commands/CommandObjectTarget.cpp
@@ -97,7 +97,7 @@ static void DumpTargetInfo(uint32_t target_idx, Target *target,
 
   uint32_t properties = 0;
   if (target_arch.IsValid()) {
-    strm.Printf("%sarch=", properties++ > 0 ? ", " : " ( ");
+    strm.Printf("%sarch=", properties > 0 ? ", " : " ( ");
     target_arch.DumpTriple(strm.AsRawOstream());
     properties++;
   }

[bulbazord]

I think you can probably just remove the check for properties value entirely. This is the first property that may be printed, so it will never be greater than 0. I think this will work:

stream.Printf(" ( arch=");

The other ones will have to stay because if the target architecture isn't valid, properties may still be 0.

Alternatively, if you feel motivated, you can rewrite the target dumping code altogether. My suggestion would be to gather all of the information up front (triple, platform, pid, state, etc) and then print it all at the end in one group so we don't have to do all these inline ternary conditions in the first place.

[xgupta]

I think you can probably just remove the check for properties value entirely. This is the first property that may be printed, so it will never be greater than 0. I think this will work:

stream.Printf(" ( arch=");

The other ones will have to stay because if the target architecture isn't valid, properties may still be 0.

Sorry have taken very long time to update the PR.

Alternatively, if you feel motivated, you can rewrite the target dumping code altogether. My suggestion would be to gather all of the information up front (triple, platform, pid, state, etc) and then print it all at the end in one group so we don't have to do all these inline ternary conditions in the first place.

I would be interested to do that, but don't know I have time and energy to do that right now. I will probably create a github issue, someone or me later can try that.