Skip to content

[NFC][SamplePGO] Refactoring getFilteredAnchorList #95830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions llvm/include/llvm/Transforms/IPO/SampleProfileMatcher.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@ class SampleProfileMatcher {
return &It->second;
return nullptr;
}
void getFilteredAnchorList(const AnchorMap &IRAnchors,
const AnchorMap &ProfileAnchors,
AnchorList &FilteredIRAnchorsList,
AnchorList &FilteredProfileAnchorList);
void runOnFunction(Function &F);
void findIRAnchors(const Function &F, AnchorMap &IRAnchors);
void findProfileAnchors(const FunctionSamples &FS, AnchorMap &ProfileAnchors);
Expand Down
26 changes: 17 additions & 9 deletions llvm/lib/Transforms/IPO/SampleProfileMatcher.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,21 @@ void SampleProfileMatcher::matchNonCallsiteLocs(
}
}

// Filter the non-call locations from IRAnchors and ProfileAnchors and write
// them into a list for random access later.
void SampleProfileMatcher::getFilteredAnchorList(
const AnchorMap &IRAnchors, const AnchorMap &ProfileAnchors,
AnchorList &FilteredIRAnchorsList, AnchorList &FilteredProfileAnchorList) {
for (const auto &I : IRAnchors) {
if (I.second.stringRef().empty())
continue;
FilteredIRAnchorsList.emplace_back(I);
}

for (const auto &I : ProfileAnchors)
FilteredProfileAnchorList.emplace_back(I);
}

// Call target name anchor based profile fuzzy matching.
// Input:
// For IR locations, the anchor is the callee name of direct callsite; For
Expand All @@ -292,16 +307,9 @@ void SampleProfileMatcher::runStaleProfileMatching(
"Run stale profile matching only once per function");

AnchorList FilteredProfileAnchorList;
for (const auto &I : ProfileAnchors)
FilteredProfileAnchorList.emplace_back(I);

AnchorList FilteredIRAnchorsList;
// Filter the non-callsite from IRAnchors.
for (const auto &I : IRAnchors) {
if (I.second.stringRef().empty())
continue;
FilteredIRAnchorsList.emplace_back(I);
}
getFilteredAnchorList(IRAnchors, ProfileAnchors, FilteredIRAnchorsList,
FilteredProfileAnchorList);

if (FilteredIRAnchorsList.empty() || FilteredProfileAnchorList.empty())
return;
Expand Down
Loading