[NFC]Fix memory leak in HeaderSearchTest

[dklimkin]

AddressSanitizer: 56 byte(s) leaked in 1 allocation(s). (clang/unittests:lex_tests)

[llvmbot]

@llvm/pr-subscribers-clang

Author: Danial Klimkin (dklimkin)

Changes

AddressSanitizer: 56 byte(s) leaked in 1 allocation(s). (clang/unittests:lex_tests)

---

Full diff: https://github.com/llvm/llvm-project/pull/95927.diff

1 Files Affected:

• (modified) clang/unittests/Lex/HeaderSearchTest.cpp (+4-2)

diff --git a/clang/unittests/Lex/HeaderSearchTest.cpp b/clang/unittests/Lex/HeaderSearchTest.cpp
index 38ce3812c204f..b0375d5985f2e 100644
--- a/clang/unittests/Lex/HeaderSearchTest.cpp
+++ b/clang/unittests/Lex/HeaderSearchTest.cpp
@@ -19,6 +19,8 @@
 #include "clang/Serialization/InMemoryModuleCache.h"
 #include "llvm/Support/MemoryBuffer.h"
 #include "gtest/gtest.h"
+#include <memory>
+#include <string>
 
 namespace clang {
 namespace {
@@ -350,8 +352,8 @@ TEST_F(HeaderSearchTest, HeaderFileInfoMerge) {
     std::string TextualPath = "/textual.h";
   };
 
-  auto ExternalSource = new MockExternalHeaderFileInfoSource();
-  Search.SetExternalSource(ExternalSource);
+  auto ExternalSource = std::make_unique<MockExternalHeaderFileInfoSource>();
+  Search.SetExternalSource(ExternalSource.get());
 
   // Everything should start out external.
   auto ModularFE = AddHeader(ExternalSource->ModularPath);

[AaronBallman]

Thank you for the fix! FWIW, I don't think this is NFC as it is changing test behavior (fixing a memory leak); please be sure to get a proper code review for functional changes. The changes are reasonable enough, but one question I have is: why not stack allocate the object rather than heap allocate it?

[dklimkin]

Hi AaronBallman, I think I opted to have a minimal change, it was on heap and I kept it this way. Seems not important for a test only code.

As per NFC, thank you for the note. I considered it NFC as the prod code behavior didn't change. I'll keep in mind any behavior change counts.