[Clang][AArch64] Use 'uint64_t*' for _arm_get_sme_state builtin.

[sdesmalen-arm]

Depending on the platform, the parameter for __arm_get_sme_state requires a unsigned long long* instead of a unsigned long*.

From ASTContext.cpp:

case 'W':
// This modifier represents int64 type.

[llvmbot]

@llvm/pr-subscribers-backend-aarch64

Author: Sander de Smalen (sdesmalen-arm)

Changes

Depending on the platform, the parameter for __arm_get_sme_state requires a unsigned long long* instead of a unsigned long*.

From ASTContext.cpp:

case 'W':
// This modifier represents int64 type.

---

Full diff: https://github.com/llvm/llvm-project/pull/95982.diff

1 Files Affected:

• (modified) clang/include/clang/Basic/BuiltinsAArch64.def (+1-1)

diff --git a/clang/include/clang/Basic/BuiltinsAArch64.def b/clang/include/clang/Basic/BuiltinsAArch64.def
index 5f53c98167dfb..5fb199b1b2b03 100644
--- a/clang/include/clang/Basic/BuiltinsAArch64.def
+++ b/clang/include/clang/Basic/BuiltinsAArch64.def
@@ -72,7 +72,7 @@ TARGET_BUILTIN(__builtin_arm_stg, "vv*", "t", "mte")
 TARGET_BUILTIN(__builtin_arm_subp, "Uiv*v*", "t", "mte")
 
 // SME state function
-BUILTIN(__builtin_arm_get_sme_state, "vULi*ULi*", "n")
+BUILTIN(__builtin_arm_get_sme_state, "vWUi*WUi*", "n")
 
 // Memory Operations
 TARGET_BUILTIN(__builtin_arm_mops_memset_tag, "v*v*iz", "", "mte,mops")

[llvmbot]

@llvm/pr-subscribers-clang

Author: Sander de Smalen (sdesmalen-arm)

Changes

Depending on the platform, the parameter for __arm_get_sme_state requires a unsigned long long* instead of a unsigned long*.

From ASTContext.cpp:

case 'W':
// This modifier represents int64 type.

---

Full diff: https://github.com/llvm/llvm-project/pull/95982.diff

1 Files Affected:

• (modified) clang/include/clang/Basic/BuiltinsAArch64.def (+1-1)

diff --git a/clang/include/clang/Basic/BuiltinsAArch64.def b/clang/include/clang/Basic/BuiltinsAArch64.def
index 5f53c98167dfb..5fb199b1b2b03 100644
--- a/clang/include/clang/Basic/BuiltinsAArch64.def
+++ b/clang/include/clang/Basic/BuiltinsAArch64.def
@@ -72,7 +72,7 @@ TARGET_BUILTIN(__builtin_arm_stg, "vv*", "t", "mte")
 TARGET_BUILTIN(__builtin_arm_subp, "Uiv*v*", "t", "mte")
 
 // SME state function
-BUILTIN(__builtin_arm_get_sme_state, "vULi*ULi*", "n")
+BUILTIN(__builtin_arm_get_sme_state, "vWUi*WUi*", "n")
 
 // Memory Operations
 TARGET_BUILTIN(__builtin_arm_mops_memset_tag, "v*v*iz", "", "mte,mops")

[sdesmalen-arm]

I've tested this change locally, but wasn't sure how to write a test for it.

[jroelofs]

I've tested this change locally, but wasn't sure how to write a test for it.

how about:

void check(uint64_t *a, uint64_t *b) {
    __builtin_arm_get_sme_state(a, b);
}

with a couple of run lines for various platforms? if a and b were unsigned long * you'd get an error about the type mismatch on an LLP64 system like:

error: cannot initialize a parameter of type 'unsigned long long *' with an lvalue of type 'unsigned long *'

Likewise, if they were unsigned long long *, you'd get the error on an LP64 system.