Skip to content

[clang][test] Enable a commented-out test #96195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

tbaederr
Copy link
Contributor

@tbaederr tbaederr commented Jun 20, 2024

I can't reproduce the assertion failure locally, let's see what the precommit CI says about it.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Jun 20, 2024
@llvmbot
Copy link
Member

llvmbot commented Jun 20, 2024

@llvm/pr-subscribers-clang

Author: Timm Baeder (tbaederr)

Changes

I can't reproduce the assertion failure locally, let's see that the precommit CI says about it.


Full diff: https://github.com/llvm/llvm-project/pull/96195.diff

1 Files Affected:

  • (modified) clang/test/CodeGenCXX/temporaries.cpp (+1-2)
diff --git a/clang/test/CodeGenCXX/temporaries.cpp b/clang/test/CodeGenCXX/temporaries.cpp
index 186f4934873fa..f992ce206c581 100644
--- a/clang/test/CodeGenCXX/temporaries.cpp
+++ b/clang/test/CodeGenCXX/temporaries.cpp
@@ -683,8 +683,7 @@ namespace Vector {
   // CHECK: store i32 {{.*}}, ptr @_ZGRN6Vector1sE_
   // CHECK: store ptr @_ZGRN6Vector1sE_, ptr @_ZN6Vector1sE,
   int &&s = S().w[1];
-  // FIXME PR16204: The following code leads to an assertion in Sema.
-  //int &&s = S().w.y;
+  int &&ss = S().w.y;
 }
 
 namespace ImplicitTemporaryCleanup {

@tbaederr tbaederr merged commit 0adecfb into llvm:main Jun 21, 2024
9 checks passed
AlexisPerry pushed a commit to llvm-project-tlp/llvm-project that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants