-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[clang-tidy] align all help message in run-clang-tidy #96199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) ChangesFull diff: https://github.com/llvm/llvm-project/pull/96199.diff 1 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
index 4dd20bec81d3b..76374933bfd15 100755
--- a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
+++ b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
@@ -264,17 +264,17 @@ def main():
help="allow alpha checkers from clang-analyzer.",
)
parser.add_argument(
- "-clang-tidy-binary", metavar="PATH", help="path to clang-tidy binary"
+ "-clang-tidy-binary", metavar="PATH", help="path to clang-tidy binary."
)
parser.add_argument(
"-clang-apply-replacements-binary",
metavar="PATH",
- help="path to clang-apply-replacements binary",
+ help="path to clang-apply-replacements binary.",
)
parser.add_argument(
"-checks",
default=None,
- help="checks filter, when not specified, use clang-tidy default",
+ help="checks filter, when not specified, use clang-tidy default.",
)
config_group = parser.add_mutually_exclusive_group()
config_group.add_argument(
@@ -350,16 +350,16 @@ def main():
help="number of tidy instances to be run in parallel.",
)
parser.add_argument(
- "files", nargs="*", default=[".*"], help="files to be processed (regex on path)"
+ "files", nargs="*", default=[".*"], help="files to be processed (regex on path)."
)
- parser.add_argument("-fix", action="store_true", help="apply fix-its")
+ parser.add_argument("-fix", action="store_true", help="apply fix-its.")
parser.add_argument(
- "-format", action="store_true", help="Reformat code after applying fixes"
+ "-format", action="store_true", help="Reformat code after applying fixes."
)
parser.add_argument(
"-style",
default="file",
- help="The style of reformat code after applying fixes",
+ help="The style of reformat code after applying fixes.",
)
parser.add_argument(
"-use-color",
@@ -388,7 +388,7 @@ def main():
help="Additional argument to prepend to the compiler command line.",
)
parser.add_argument(
- "-quiet", action="store_true", help="Run clang-tidy in quiet mode"
+ "-quiet", action="store_true", help="Run clang-tidy in quiet mode."
)
parser.add_argument(
"-load",
@@ -400,7 +400,7 @@ def main():
parser.add_argument(
"-warnings-as-errors",
default=None,
- help="Upgrades warnings to errors. Same format as '-checks'",
+ help="Upgrades warnings to errors. Same format as '-checks'.",
)
args = parser.parse_args()
|
@llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) ChangesFull diff: https://github.com/llvm/llvm-project/pull/96199.diff 1 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
index 4dd20bec81d3b..76374933bfd15 100755
--- a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
+++ b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
@@ -264,17 +264,17 @@ def main():
help="allow alpha checkers from clang-analyzer.",
)
parser.add_argument(
- "-clang-tidy-binary", metavar="PATH", help="path to clang-tidy binary"
+ "-clang-tidy-binary", metavar="PATH", help="path to clang-tidy binary."
)
parser.add_argument(
"-clang-apply-replacements-binary",
metavar="PATH",
- help="path to clang-apply-replacements binary",
+ help="path to clang-apply-replacements binary.",
)
parser.add_argument(
"-checks",
default=None,
- help="checks filter, when not specified, use clang-tidy default",
+ help="checks filter, when not specified, use clang-tidy default.",
)
config_group = parser.add_mutually_exclusive_group()
config_group.add_argument(
@@ -350,16 +350,16 @@ def main():
help="number of tidy instances to be run in parallel.",
)
parser.add_argument(
- "files", nargs="*", default=[".*"], help="files to be processed (regex on path)"
+ "files", nargs="*", default=[".*"], help="files to be processed (regex on path)."
)
- parser.add_argument("-fix", action="store_true", help="apply fix-its")
+ parser.add_argument("-fix", action="store_true", help="apply fix-its.")
parser.add_argument(
- "-format", action="store_true", help="Reformat code after applying fixes"
+ "-format", action="store_true", help="Reformat code after applying fixes."
)
parser.add_argument(
"-style",
default="file",
- help="The style of reformat code after applying fixes",
+ help="The style of reformat code after applying fixes.",
)
parser.add_argument(
"-use-color",
@@ -388,7 +388,7 @@ def main():
help="Additional argument to prepend to the compiler command line.",
)
parser.add_argument(
- "-quiet", action="store_true", help="Run clang-tidy in quiet mode"
+ "-quiet", action="store_true", help="Run clang-tidy in quiet mode."
)
parser.add_argument(
"-load",
@@ -400,7 +400,7 @@ def main():
parser.add_argument(
"-warnings-as-errors",
default=None,
- help="Upgrades warnings to errors. Same format as '-checks'",
+ help="Upgrades warnings to errors. Same format as '-checks'.",
)
args = parser.parse_args()
|
3619435
to
03bc40a
Compare
✅ With the latest revision this PR passed the Python code formatter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you add a .
to make the help messages sentences, then you might want to capitalize the first word as well.
No description provided.