[mlir] Exclude CAPI test targets from default build target #96545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps reduce the build time for users that want to build MLIR, but don't want to run the tests.
|
@llvm/pr-subscribers-mlir Author: Tom Stellard (tstellar) ChangesThis helps reduce the build time for users that want to build MLIR, but don't want to run the tests. Full diff: https://github.com/llvm/llvm-project/pull/96545.diff 1 Files Affected:
diff --git a/mlir/test/CAPI/CMakeLists.txt b/mlir/test/CAPI/CMakeLists.txt
index 76bd4e60f77b2..ad312764b3e06 100644
--- a/mlir/test/CAPI/CMakeLists.txt
+++ b/mlir/test/CAPI/CMakeLists.txt
@@ -10,6 +10,7 @@ function(_add_capi_test_executable name)
PARTIAL_SOURCES_INTENDED
${ARG_UNPARSED_ARGUMENTS})
set_target_properties(${name} PROPERTIES FOLDER "MLIR/Tests")
+ set_target_properties(${name} PROPERTIES EXCLUDE_FROM_ALL ON)
llvm_update_compile_flags(${name})
if(MLIR_BUILD_MLIR_C_DYLIB)
|
|
Ping. |
joker-eph
approved these changes
Jul 3, 2024
|
Are they still a dependency of check-mlir-build-only though? |
Yes, I confirmed this by testing locally. Also, the dependencies for |
aaryanshukla
pushed a commit
to aaryanshukla/llvm-project
that referenced
this pull request
Jul 14, 2024
This helps reduce the build time for users that want to build MLIR, but don't want to run the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps reduce the build time for users that want to build MLIR, but don't want to run the tests.