[NFC][MLInliner] Rename LastSCC -> CurSCC #96546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The passed SCC is the current SCC we're working on.
llvmbot
added
mlgo
llvm:analysis
|
@llvm/pr-subscribers-llvm-analysis @llvm/pr-subscribers-mlgo Author: Arthur Eubanks (aeubanks) ChangesThe passed SCC is the current SCC we're working on. Full diff: https://github.com/llvm/llvm-project/pull/96546.diff 1 Files Affected:
diff --git a/llvm/lib/Analysis/MLInlineAdvisor.cpp b/llvm/lib/Analysis/MLInlineAdvisor.cpp
index 21946572339b9..934c0cfb6e20c 100644
--- a/llvm/lib/Analysis/MLInlineAdvisor.cpp
+++ b/llvm/lib/Analysis/MLInlineAdvisor.cpp
@@ -187,8 +187,8 @@ unsigned MLInlineAdvisor::getInitialFunctionLevel(const Function &F) const {
return CG.lookup(F) ? FunctionLevels.at(CG.lookup(F)) : 0;
}
-void MLInlineAdvisor::onPassEntry(LazyCallGraph::SCC *LastSCC) {
- if (!LastSCC || ForceStop)
+void MLInlineAdvisor::onPassEntry(LazyCallGraph::SCC *CurSCC) {
+ if (!CurSCC || ForceStop)
return;
FPICache.clear();
// Function passes executed between InlinerPass runs may have changed the
@@ -235,15 +235,15 @@ void MLInlineAdvisor::onPassEntry(LazyCallGraph::SCC *LastSCC) {
// (Re)use NodesInLastSCC to remember the nodes in the SCC right now,
// in case the SCC is split before onPassExit and some nodes are split out
assert(NodesInLastSCC.empty());
- for (const auto &N : *LastSCC)
+ for (const auto &N : *CurSCC)
NodesInLastSCC.insert(&N);
}
-void MLInlineAdvisor::onPassExit(LazyCallGraph::SCC *LastSCC) {
+void MLInlineAdvisor::onPassExit(LazyCallGraph::SCC *CurSCC) {
// No need to keep this around - function passes will invalidate it.
if (!KeepFPICache)
FPICache.clear();
- if (!LastSCC || ForceStop)
+ if (!CurSCC || ForceStop)
return;
// Keep track of the nodes and edges we last saw. Then, in onPassEntry,
// we update the node count and edge count from the subset of these nodes that
@@ -259,7 +259,7 @@ void MLInlineAdvisor::onPassExit(LazyCallGraph::SCC *LastSCC) {
}
// Check on nodes that may have got added to SCC
- for (const auto &N : *LastSCC) {
+ for (const auto &N : *CurSCC) {
assert(!N.isDead());
auto I = NodesInLastSCC.insert(&N);
if (I.second)
|
mtrofin
approved these changes
Jun 24, 2024
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/69/builds/603 Here is the relevant piece of the build log for the reference: |
AlexisPerry
pushed a commit
to llvm-project-tlp/llvm-project
that referenced
this pull request
Jul 9, 2024
The passed SCC is the current SCC we're working on.
anton-bannykh
pushed a commit
to Kotlin/llvm-project
that referenced
this pull request
Aug 23, 2024
The passed SCC is the current SCC we're working on. (cherry picked from commit 0555afd)
anton-bannykh
pushed a commit
to Kotlin/llvm-project
that referenced
this pull request
Aug 23, 2024
The passed SCC is the current SCC we're working on. (cherry picked from commit 0555afd)
anton-bannykh
pushed a commit
to Kotlin/llvm-project
that referenced
this pull request
Aug 26, 2024
The passed SCC is the current SCC we're working on. (cherry picked from commit 0555afd)
anton-bannykh
pushed a commit
to Kotlin/llvm-project
that referenced
this pull request
Aug 26, 2024
The passed SCC is the current SCC we're working on. (cherry picked from commit 0555afd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The passed SCC is the current SCC we're working on.