Skip to content

[BOLT][NFC] Sync CommandLineArgumentReference with options #96563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

shawbyoung
Copy link
Contributor

@shawbyoung shawbyoung commented Jun 24, 2024

Test Plan: n/a

Created using spr 1.3.4
@llvmbot
Copy link
Member

llvmbot commented Jun 24, 2024

@llvm/pr-subscribers-bolt

Author: shaw young (shawbyoung)

Changes

Test Plan: n/a


Full diff: https://github.com/llvm/llvm-project/pull/96563.diff

1 Files Affected:

  • (modified) bolt/docs/CommandLineArgumentReference.md (+3-3)
diff --git a/bolt/docs/CommandLineArgumentReference.md b/bolt/docs/CommandLineArgumentReference.md
index 49e226513028f..7a77e8eda18b2 100644
--- a/bolt/docs/CommandLineArgumentReference.md
+++ b/bolt/docs/CommandLineArgumentReference.md
@@ -804,8 +804,8 @@
 
 - `--stale-matching-min-matched-block=<uint>`
 
-  Minimum percent of exact match block for a function to be considered for
-  profile inference.
+  Percentage threshold of matched basic blocks at which stale profile inference
+  is executed.
 
 - `--stale-threshold=<uint>`
 
@@ -1166,4 +1166,4 @@
 
 - `--print-options`
 
-  Print non-default options after command line parsing
+  Print non-default options after command line parsing
\ No newline at end of file

@shawbyoung shawbyoung changed the title [BOLT] Sync doc for dropping disparate profiles [BOLT][NFC] Sync doc for dropping disparate profiles Jun 24, 2024
Created using spr 1.3.4
@aaupov
Copy link
Contributor

aaupov commented Jun 24, 2024

Please update the whole markdown. Doesn't make sense to go after changes one by one.

Created using spr 1.3.4
@shawbyoung shawbyoung changed the title [BOLT][NFC] Sync doc for dropping disparate profiles [BOLT][NFC] Sync docs Jun 24, 2024
Copy link
Contributor

@aaupov aaupov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aaupov
Copy link
Contributor

aaupov commented Jun 24, 2024

Please retitle to "[BOLT][NFC] Sync CommandLineArgumentReference with options"

@shawbyoung shawbyoung changed the title [BOLT][NFC] Sync docs [BOLT][NFC] Sync CommandLineArgumentReference with options Jun 24, 2024
@shawbyoung shawbyoung merged commit 75ac887 into main Jun 24, 2024
4 of 5 checks passed
@shawbyoung shawbyoung deleted the users/shawbyoung/spr/bolt-sync-doc-for-dropping-disparate-profiles branch June 24, 2024 22:16
AlexisPerry pushed a commit to llvm-project-tlp/llvm-project that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants