Fix MSVC Demangling with auto NTTP mangled names for function pointer, pointer to data and integral types #96590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and pointers to variables
MaxEW707
commented
Jun 25, 2024
| llvm::itanium_demangle::starts_with(MangledName, "$H") || | ||
| llvm::itanium_demangle::starts_with(MangledName, "$I") || | ||
| llvm::itanium_demangle::starts_with(MangledName, "$J")) { | ||
| } else if (startsWithOrWithoutPrefix(MangledName, "$1", IsAutoNTTP, 1) || |
There was a problem hiding this comment.
I am not super happy with this fix but it was the cleanest way I could come up with to support $M within the current infrastructure with minimal code changes.
Once I fix the rest of the name mangling issues in clang I need to come back here and most likely refactor how we demangle the template parameter list with a now larger holistic view of the different mangling schemes MSVC has.
zmodem
approved these changes
Jun 26, 2024
| @@ -53,6 +53,18 @@ static bool consumeFront(std::string_view &S, std::string_view C) { | |||
| return true; | |||
| } | |||
|
|
|||
| static bool consumeFront(std::string_view &S, std::string_view CA, | |||
There was a problem hiding this comment.
nit: I'm guessing the C in these parameter names is really for "character", based on the initial overload on line 42. Maybe we could find better names for the string_views (how about Prefix?)
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/108/builds/501 Here is the relevant piece of the build log for the reference: |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/649 Here is the relevant piece of the build log for the reference: |
lravenclaw
pushed a commit
to lravenclaw/llvm-project
that referenced
this pull request
Jul 3, 2024
…, pointer to data and integral types (llvm#96590) As cited here, llvm#92477, undname needs updating to support the new auto NTTP name mangling. In short the deduced type of the auto NTTP parameter is mangled as `$M <type> <nttp-param>`. However the deduced type is not printed for the undecorated name so the `$M <type>` is parsed but simply ignored when stringifying the generated AST.
AlexisPerry
pushed a commit
to llvm-project-tlp/llvm-project
that referenced
this pull request
Jul 9, 2024
…, pointer to data and integral types (llvm#96590) As cited here, llvm#92477, undname needs updating to support the new auto NTTP name mangling. In short the deduced type of the auto NTTP parameter is mangled as `$M <type> <nttp-param>`. However the deduced type is not printed for the undecorated name so the `$M <type>` is parsed but simply ignored when stringifying the generated AST.
Ryan-rsm-McKenzie
added a commit
to Ryan-rsm-McKenzie/undname-rs
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As cited here, #92477, undname needs updating to support the new auto NTTP name mangling.
In short the deduced type of the auto NTTP parameter is mangled as
$M <type> <nttp-param>. However the deduced type is not printed for the undecorated name so the$M <type>is parsed but simply ignored when stringifying the generated AST.