-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[clang][docs] Add preliminary documentation for SPIR-V support in the HIPAMD ToolChain #96657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
662f160
Add initial support for AMDGCN flavoured SPIRV.
AlexVlx 393ce66
Fix formatting.
AlexVlx 2a10ad0
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 98db8f7
Use `fillAMDGPUFeatureMap` instead of copy-pasta.
AlexVlx c359e0a
Add `__has_builtin` test.
AlexVlx e98f3f5
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx c41726d
Re-use `AMDGPUTargetInfo`, where feasible, instead of copypasta-ing.
AlexVlx 4698b58
Incorporate review suggestions.
AlexVlx aa1cd7c
Fix header ordering.
AlexVlx f9729ef
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 8257cb1
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 900cd69
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 3307f17
Handle `wavefrontsize` (we need both 32 and 64); add more tests.
AlexVlx eee6063
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx d2f4244
Add an additional test.
AlexVlx 4cb4026
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 84a621d
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 1841385
AMDGCN SPIRV should allow both AMDGCN and SPIRV builtins.
AlexVlx 0ce2da3
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 120b73c
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx f3942bd
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 31ac77d
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 0e9b1a1
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 83cd5e0
Enable AMDGCN flavoured SPIRV in the experimental SPIRV BE.
AlexVlx e9158b0
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 05074e7
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx e1fb93f
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 36c4bf6
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 5ffa186
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx cf1880c
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 4d85a1b
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 516e14c
Revert spurios testing noise, AMDGCN SPIRV is still SPIRV.
AlexVlx bdc3eb5
First pass at updating SPIR-V docs to reflect the addition of AMDGCN …
AlexVlx 361d47b
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx b088c72
Fix erroneous versioning claim.
AlexVlx e85b557
Remove function pointer tests.
AlexVlx 1d41787
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 8bcf2b2
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 9b3275b
Add HIP Driver support for AMDGCN flavoured SPIRV.
AlexVlx 5b764ec
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx ba3fb6f
Fix formatting.
AlexVlx 3719c3b
Revert changing the HIPAMD default to SPIR-V; tweak some tests.
AlexVlx 7ca1c87
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx f3e5145
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 089bb9b
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx b60e753
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 8741e7c
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 5f775b8
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 4aa60c7
Fix warning.
AlexVlx 1c2d0fa
Fix broken test.
AlexVlx e8a78a2
Reorder check.
AlexVlx 294cd9c
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx f712c53
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx fe927e0
Do not allow mixing SPIR-V & concrete `offload-arch`s for now.
AlexVlx 5ce5497
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 2220d37
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 83ec34c
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx 887df00
Merge branch 'main' of https://github.com/llvm/llvm-project into amdg…
AlexVlx d281831
Add preliminary documentation for HIPAMD support for AMDGCN flavoured…
AlexVlx a3d42cb
Fix typo.
AlexVlx 1fdcd9b
Correct the bundle id.
AlexVlx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need to play with this with my driver code. I'm guessing it's because it needs to generate an entirely separate toolchain? The OpenMP path basically does that by inferring the toolchain from the string value, so we can support
--offload-arch=sm_89,gfx90a
for example.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need HIPAMD toolchain instead of HIPSPIRV toolchain because we want to locate the tools and device libraries on ROCm platform and do argument translation using amdgpu information like we are compiling for any amdgpu processors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yxsamliu is correct, the HIPSPIRV toolchain is matched to a different downstream ecosystem.