[InstCombine] Simplify matchers (NFC)

[AZero13]

No description provided.

[llvmbot]

@llvm/pr-subscribers-llvm-transforms

Author: AtariDreams (AtariDreams)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/96665.diff

1 Files Affected:

• (modified) llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp (+1-2)

diff --git a/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp b/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
index 19a12343748df..b8664089c36ce 100644
--- a/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
@@ -3655,8 +3655,7 @@ Instruction *InstCombinerImpl::visitOr(BinaryOperator &I) {
 
     // (A & B) | (A ^ B) --> A | B
     // (B & A) | (A ^ B) --> A | B
-    if (match(Op0, m_And(m_Specific(A), m_Specific(B))) ||
-        match(Op0, m_And(m_Specific(B), m_Specific(A))))
+    if (match(Op0, m_c_And(m_Specific(A), m_Specific(B))))
       return BinaryOperator::CreateOr(A, B);
 
     // ~A | (A ^ B) --> ~(A & B)

[nikic]

LGTM. Some of these are non-canonical, but I guess we can keep them in the interest of keeping this change NFC.

[AZero13]

LGTM. Some of these are non-canonical, but I guess we can keep them in the interest of keeping this change NFC.

Tell me which ones so I can cut down on them

[goldsteinn]

LGTM. Some of these are non-canonical, but I guess we can keep them in the interest of keeping this change NFC.

Tell me which ones so I can cut down on them

All the ones where the constant is on the LHS i.e

  if (!match(C, m_And(m_Value(X), m_One())) &&
      !match(C, m_And(m_One(), m_Value(X))))

but probably just get this in as is then follow up patch to remove the m_c from the non-canonical cases.