Skip to content

Fix for broken test following merge of PR #95043 #96683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

AlexisPerry
Copy link
Contributor

fix post-commit broken test from #95043, add test for aarch64

@llvmbot llvmbot added flang Flang issues not falling into any other category flang:fir-hlfir labels Jun 25, 2024
@llvmbot
Copy link
Member

llvmbot commented Jun 25, 2024

@llvm/pr-subscribers-flang-fir-hlfir

Author: Alexis Perry-Holby (AlexisPerry)

Changes

fix post-commit broken test from #95043, add test for aarch64


Full diff: https://github.com/llvm/llvm-project/pull/96683.diff

2 Files Affected:

  • (added) flang/test/Lower/tune-cpu-llvm-aarch.f90 (+7)
  • (modified) flang/test/Lower/tune-cpu-llvm.f90 (+1)
diff --git a/flang/test/Lower/tune-cpu-llvm-aarch.f90 b/flang/test/Lower/tune-cpu-llvm-aarch.f90
new file mode 100644
index 0000000000000..bd121784af721
--- /dev/null
+++ b/flang/test/Lower/tune-cpu-llvm-aarch.f90
@@ -0,0 +1,7 @@
+! REQUIRES: aarch64-registered-target
+! RUN: %flang -mtune=neoverse-n1 -S -emit-llvm %s -o - | FileCheck %s
+
+!CHECK: attributes #{{[0-9]+}} = {
+!CHECK-SAME: "tune-cpu"="neoverse-n1"
+subroutine a
+end subroutine a
diff --git a/flang/test/Lower/tune-cpu-llvm.f90 b/flang/test/Lower/tune-cpu-llvm.f90
index aa6594bc76312..e3a63c3225df9 100644
--- a/flang/test/Lower/tune-cpu-llvm.f90
+++ b/flang/test/Lower/tune-cpu-llvm.f90
@@ -1,3 +1,4 @@
+! REQUIRES: x86-registered-target
 ! RUN: %flang -mtune=pentium4 -S -emit-llvm %s -o - | FileCheck %s
 
 !CHECK: attributes #{{[0-9]+}} = {

@AlexisPerry
Copy link
Contributor Author

Closing in favor of PR #96688

@AlexisPerry AlexisPerry deleted the AlexisPerry/mtune-fix branch July 16, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:fir-hlfir flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants