gn: hwasan: fixup hwasan-preinit #96748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build rule for hwasan_preinit outputs libclang_rt.hwasan_preinit, but clang expects hwasan-preinit (with a dash, rather than an underscore) when selecting the library in the frontend. Also, we were missing the hwasan-preinit dependency in check-hwasan. For posterity, this now passes hwasan unit tests on Android with: $ cat args.gn clang_base_path = "/usr/local" llvm_enable_assertions = true llvm_targets_to_build = "all" android_ndk_path = "/path/to/Android.sdk/ndk/25.2.9519653" $ /path/to/llvm/utils/gn/gn.py gen build $ ANDROID_SERIAL=xxx ninja -C build check-hwasan
pcc
approved these changes
Jun 26, 2024
lravenclaw
pushed a commit
to lravenclaw/llvm-project
that referenced
this pull request
Jul 3, 2024
The build rule for hwasan_preinit outputs libclang_rt.hwasan_preinit, but clang expects hwasan-preinit (with a dash, rather than an underscore) when selecting the library in the frontend. Also, we were missing the hwasan-preinit dependency in check-hwasan. For posterity, this now passes hwasan unit tests on Android with: $ cat args.gn clang_base_path = "/usr/local" llvm_enable_assertions = true llvm_targets_to_build = "all" android_ndk_path = "/path/to/Android.sdk/ndk/25.2.9519653" $ /path/to/llvm/utils/gn/gn.py gen build $ ANDROID_SERIAL=xxx ninja -C build check-hwasan
AlexisPerry
pushed a commit
to llvm-project-tlp/llvm-project
that referenced
this pull request
Jul 9, 2024
The build rule for hwasan_preinit outputs libclang_rt.hwasan_preinit, but clang expects hwasan-preinit (with a dash, rather than an underscore) when selecting the library in the frontend. Also, we were missing the hwasan-preinit dependency in check-hwasan. For posterity, this now passes hwasan unit tests on Android with: $ cat args.gn clang_base_path = "/usr/local" llvm_enable_assertions = true llvm_targets_to_build = "all" android_ndk_path = "/path/to/Android.sdk/ndk/25.2.9519653" $ /path/to/llvm/utils/gn/gn.py gen build $ ANDROID_SERIAL=xxx ninja -C build check-hwasan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build rule for hwasan_preinit outputs libclang_rt.hwasan_preinit,
but clang expects hwasan-preinit (with a dash, rather than an
underscore) when selecting the library in the frontend.
Also, we were missing the hwasan-preinit dependency in check-hwasan.
For posterity, this now passes hwasan unit tests on Android with:
$ cat args.gn
clang_base_path = "/usr/local"
llvm_enable_assertions = true
llvm_targets_to_build = "all"
android_ndk_path = "/path/to/Android.sdk/ndk/25.2.9519653"
$ /path/to/llvm/utils/gn/gn.py gen build
$ ANDROID_SERIAL=xxx ninja -C build check-hwasan