Skip to content

[OpenMP] Fix test omp_parallel_num_threads_list.c to require fewer threads. #96916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

TerryLWilmarth
Copy link
Contributor

@TerryLWilmarth TerryLWilmarth commented Jun 27, 2024

Original test case used too many threads for some tests. This update reduces to a max of 36 threads.

@llvmbot llvmbot added the openmp:libomp OpenMP host runtime label Jun 27, 2024
@TerryLWilmarth TerryLWilmarth changed the title Fix test omp_parallel_num_threads_list.c to require fewer threads. [OpenMP] Fix test omp_parallel_num_threads_list.c to require fewer threads. Jun 27, 2024
@TerryLWilmarth TerryLWilmarth requested a review from mstorsjo June 27, 2024 15:20
Copy link
Member

@mstorsjo mstorsjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this seems to fix the issues on 32 bit windows! Thanks!

@mstorsjo mstorsjo merged commit ac9f06c into llvm:main Jun 27, 2024
7 checks passed
@mstorsjo
Copy link
Member

I merged this now, to get my nightly testing back to green. Thanks!

@jprotze
Copy link
Collaborator

jprotze commented Jun 28, 2024

I think, this test should check omp_get_thread_limit() and just exit (successfully ?), if not enough threads are available for the test.

lravenclaw pushed a commit to lravenclaw/llvm-project that referenced this pull request Jul 3, 2024
…reads. (llvm#96916)

Original test case used too many threads for some environments. This update
reduces to a max of 36 threads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomp OpenMP host runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants