[clang] Fix incomplete umbrella warnings when building clang modules (NFC) #96939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lldb @llvm/pr-subscribers-clang Author: Med Ismail Bennani (medismailben) ChangesThis patch silences the incomplete-umbrella warnings when building clang modules, by adding the missing textual headers to the clang module map. Full diff: https://github.com/llvm/llvm-project/pull/96939.diff 1 Files Affected:
diff --git a/clang/include/module.modulemap b/clang/include/module.modulemap
index acd960c9c932a..a8ee223126690 100644
--- a/clang/include/module.modulemap
+++ b/clang/include/module.modulemap
@@ -22,6 +22,7 @@ module Clang_AST {
requires cplusplus
umbrella "clang/AST"
+ textual header "clang/Basic/OpenACCClauses.def"
textual header "clang/AST/BuiltinTypes.def"
textual header "clang/AST/CXXRecordDeclDefinitionBits.def"
textual header "clang/AST/OperationKinds.def"
@@ -37,6 +38,7 @@ module Clang_Basic {
umbrella "clang/Basic"
textual header "clang/Basic/AArch64SVEACLETypes.def"
+ textual header "clang/Basic/AMDGPUTypes.def"
textual header "clang/Basic/BuiltinsAArch64.def"
textual header "clang/Basic/BuiltinsAMDGPU.def"
textual header "clang/Basic/BuiltinsAArch64NeonSVEBridge.def"
|
…(NFC) This patch silences the incomplete-umbrella warnings when building clang modules, by adding and sorting the missing textual headers to the clang module map. Signed-off-by: Med Ismail Bennani <[email protected]>
medismailben
force-pushed
the
fix-clang-module-build
branch
from
8de45df to
5639216
Compare
medismailben
force-pushed
the
fix-clang-module-build
branch
from
5639216 to
7d0a3e3
Compare
jansvoboda11
approved these changes
Jun 27, 2024
lravenclaw
pushed a commit
to lravenclaw/llvm-project
that referenced
this pull request
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch silences the incomplete-umbrella warnings when building clang modules, by adding the missing textual headers to the clang module map.