[NFC] [clang][SPIR-V] Use AMDGPU prefix to avoid confusion #96962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reusing prefix SPIRV64 while adding an useless(and wrong) line AMDGPUSPIRV64 is confusing. Update it by copying SPIRV64 line to AMDGPU line.
|
@llvm/pr-subscribers-clang Author: Jinsong Ji (jsji) ChangesReusing prefix SPIRV64 while adding an useless(and wrong) line Update it by copying SPIRV64 line to AMDGPU line. Full diff: https://github.com/llvm/llvm-project/pull/96962.diff 1 Files Affected:
diff --git a/clang/test/CodeGen/target-data.c b/clang/test/CodeGen/target-data.c
index 7f7005d21b99a..e3dddb6d14fb0 100644
--- a/clang/test/CodeGen/target-data.c
+++ b/clang/test/CodeGen/target-data.c
@@ -270,5 +270,5 @@
// VE: target datalayout = "e-m:e-i64:64-n32:64-S128-v64:64:64-v128:64:64-v256:64:64-v512:64:64-v1024:64:64-v2048:64:64-v4096:64:64-v8192:64:64-v16384:64:64"
// RUN: %clang_cc1 -triple spirv64-amd -o - -emit-llvm %s | \
-// RUN: FileCheck %s -check-prefix=SPIR64
-// AMDGPUSPIRV64: target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-G1-P4-A0"
+// RUN: FileCheck %s -check-prefix=AMDGPUSPIRV64
+// AMDGPUSPIRV64: target datalayout = "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-G1"
|
AlexVlx
requested changes
Jun 27, 2024
AlexVlx
approved these changes
Jun 28, 2024
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/733 Here is the relevant piece of the build log for the reference: |
Flaky failure. |
lravenclaw
pushed a commit
to lravenclaw/llvm-project
that referenced
this pull request
Jul 3, 2024
Reusing prefix SPIRV64 while adding an useless(and wrong) line AMDGPUSPIRV64 is confusing. Update it by copying SPIRV64 line to AMDGPU line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reusing prefix SPIRV64 while adding an useless(and wrong) line
AMDGPUSPIRV64 is confusing.
Update it by copying SPIRV64 line to AMDGPU line.