[mlir] Fix -Wextra-semi warnings in generated code (NFC) #96981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While building a downstream project including `mlir-tblgen`-generated headers, I received some `-Wextra-semi` warnings. Fix these in the generated code by removing the extra semicolon in the generator.
|
@llvm/pr-subscribers-mlir-core @llvm/pr-subscribers-mlir Author: None (akirchhoff-modular) ChangesWhile building a downstream project including Full diff: https://github.com/llvm/llvm-project/pull/96981.diff 1 Files Affected:
diff --git a/mlir/tools/mlir-tblgen/RewriterGen.cpp b/mlir/tools/mlir-tblgen/RewriterGen.cpp
index b8a3d5b49938e..0d3b29cc94e84 100644
--- a/mlir/tools/mlir-tblgen/RewriterGen.cpp
+++ b/mlir/tools/mlir-tblgen/RewriterGen.cpp
@@ -1117,7 +1117,7 @@ void PatternEmitter::emit(StringRef rewriteName) {
os << "return ::mlir::success();\n";
}
- os << "};\n";
+ os << "}\n";
}
os << "};\n\n";
}
|
naibaf7
approved these changes
Jun 27, 2024
lravenclaw
pushed a commit
to lravenclaw/llvm-project
that referenced
this pull request
Jul 3, 2024
While building a downstream project including `mlir-tblgen`-generated headers, I received some `-Wextra-semi` warnings. Fix these in the generated code by removing the extra semicolon in the generator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building a downstream project including
mlir-tblgen-generated headers, I received some-Wextra-semiwarnings. Fix these in the generated code by removing the extra semicolon in the generator.