Skip to content

[lldb][test] Remove duplicate testcase names in API test-suite #97043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def test_disable_empty(self):
)

@no_debug_info_test
def test_enable_empty(self):
def test_enable_invalid_path(self):
invalid_path = os.path.join("this", "is", "not", "a", "valid", "path")
self.expect(
"log enable lldb all -f " + invalid_path,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ def test_thread_backtrace_one_thread(self):
"""Run a simplified version of the test that just hits one breakpoint and
doesn't care about synchronizing the two threads - hopefully this will
run on more systems."""

def test_thread_backtrace_one_thread(self):
self.build()
(
self.inferior_target,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,43 +31,6 @@ def testStartMultipleLiveThreads(self):

self.traceStopProcess()

@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
@testSBAPIAndCommands
def testStartMultipleLiveThreadsWithStops(self):
self.build()
exe = self.getBuildArtifact("a.out")

self.dbg.CreateTarget(exe)

self.expect("b main")
self.expect("b 6")
self.expect("b 11")

self.expect("r")
self.traceStartProcess()

# We'll see here the first thread
self.expect("continue")

# We are in thread 2
self.expect("thread trace dump instructions", substrs=["main.cpp:9"])
self.expect("thread trace dump instructions 2", substrs=["main.cpp:9"])

# We stop tracing it
self.expect("thread trace stop 2")

# The trace is still in memory
self.expect("thread trace dump instructions 2", substrs=["main.cpp:9"])

# We'll stop at the next breakpoint, thread 2 will be still alive, but not traced. Thread 3 will be traced
self.expect("continue")
self.expect("thread trace dump instructions", substrs=["main.cpp:4"])
self.expect("thread trace dump instructions 3", substrs=["main.cpp:4"])

self.expect("thread trace dump instructions 2", substrs=["not traced"])

self.traceStopProcess()

@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
@testSBAPIAndCommands
def testStartMultipleLiveThreadsWithStops(self):
Expand Down
6 changes: 0 additions & 6 deletions lldb/test/API/functionalities/completion/TestCompletion.py
Original file line number Diff line number Diff line change
Expand Up @@ -196,12 +196,6 @@ def test_disassemble_dash_f(self):
def test_plugin_load(self):
self.complete_from_to("plugin load ", [])

def test_log_enable(self):
self.complete_from_to("log enable ll", ["lldb"])
self.complete_from_to("log enable dw", ["dwarf"])
self.complete_from_to("log enable lldb al", ["all"])
self.complete_from_to("log enable lldb sym", ["symbol"])

def test_log_enable(self):
self.complete_from_to("log disable ll", ["lldb"])
self.complete_from_to("log disable dw", ["dwarf"])
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def test_tvos_sim(self):
)

@skipIfRemote
def test_tvos_sim(self):
def test_watchos_sim(self):
self.platform_test(
host="macosx",
process="watchossimulator",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def test_python_os_plugin(self):
self.build()
self.run_python_os_funcionality()

def run_python_os_step(self):
def test_run_python_os_step(self):
"""Test that the Python operating system plugin works correctly when single stepping a virtual thread"""
self.build()
self.run_python_os_step()
Expand Down
2 changes: 1 addition & 1 deletion lldb/test/API/lang/cpp/diamond/TestCppDiamond.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def test(self):

@expectedFailureAll
@no_debug_info_test
def test(self):
def test_invalid_member(self):
self.build()
lldbutil.run_to_source_breakpoint(
self, "// breakpoint 1", lldb.SBFileSpec("main.cpp")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
class TestObjCXXBridgedPO(TestBase):
@skipIfDarwinEmbedded
@skipIf(macos_version=[">=", "13.0"])
def test_bridged_type_po(self):
def test_bridged_type_po_old(self):
self.build()
lldbutil.run_to_source_breakpoint(
self, "break here", lldb.SBFileSpec("main.mm")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ def test_niche_layout_with_fields_3_a(self):
(137, 1),
)

def test_niche_layout_with_fields_3_a(self):
def test_niche_layout_with_fields_3_c(self):
# static NICHE_W_FIELDS_3_C: NicheLayoutWithFields3 = NicheLayoutWithFields3::C(false);
value = self.getFromGlobal("NICHE_W_FIELDS_3_C").getCurrentValue()
self.assertEqual(
Expand Down
4 changes: 2 additions & 2 deletions lldb/test/API/test_utils/TestDecorators.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def test_add_test_categories(self):
self.assertIsNone(self.getDebugInfo())

@expectedFailureAll
def test_xfail_regexp(self):
def test_xfail_empty(self):
"""Test that expectedFailureAll can be empty (but please just use expectedFailure)"""
self.fail()

Expand Down Expand Up @@ -92,7 +92,7 @@ def test_decorator_skip2(self):
# self.assertNotEqual(self.getDebugInfo(), "dwarf")

@expectedFailureAll
def test_xfail_regexp(self):
def test_xfail_empty(self):
"""Test that xfail can be empty"""
self.fail()

Expand Down
Loading