Skip to content

[OpenMP] Add ompt_start_tool declaration in omp-tools.h #97099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2024
Merged

[OpenMP] Add ompt_start_tool declaration in omp-tools.h #97099

merged 2 commits into from
Jul 3, 2024
+8 −0

Conversation

hansangbae
Copy link
Contributor

The function ompt_start_tool is a globally-visible C function according to the specification.

@hansangbae hansangbae force-pushed the 20240628-ompt-start-tool branch from 4d6a0cf to fb76d2c Compare June 28, 2024 19:26
@hansangbae hansangbae added the openmp:libomp OpenMP host runtime label Jun 28, 2024
@hansangbae
[OpenMP] Add ompt_start_tool declaration in omp-tools.h
c902e67 
The function ompt_start_tool is a globally-visible C function according
to the specification.
@hansangbae hansangbae force-pushed the 20240628-ompt-start-tool branch from fb76d2c to c902e67 Compare June 28, 2024 19:47
@hansangbae hansangbae marked this pull request as ready for review June 28, 2024 19:52
jprotze
jprotze reviewed Jul 3, 2024
View reviewed changes
jprotze
jprotze approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@jprotze jprotze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@hansangbae hansangbae merged commit d4f3d24 into llvm:main Jul 3, 2024
5 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Jul 3, 2024

LLVM Buildbot has detected a new failure on builder openmp-offload-libc-amdgpu-runtime running on omp-vega20-1 while building openmp at step 6 "test-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/1173

Here is the relevant piece of the build log for the reference:

Step 6 (test-openmp) failure: test (failure)
******************** TEST 'ompd-test :: openmp_examples/example_2.c' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./bin/clang -fopenmp -g -gdwarf-4 /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/openmp/libompd/test/openmp_examples/example_2.c -o /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/libompd/test/openmp_examples/Output/example_2.c.tmp  -I /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/openmp/libompd/test -I /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src  -L /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src 2>&1 | tee /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/libompd/test/openmp_examples/Output/example_2.c.tmp.compile
# executed command: /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./bin/clang -fopenmp -g -gdwarf-4 /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/openmp/libompd/test/openmp_examples/example_2.c -o /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/libompd/test/openmp_examples/Output/example_2.c.tmp -I /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/openmp/libompd/test -I /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -L /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src
# note: command had no output on stdout or stderr
# error: command failed with exit status: 1
# executed command: tee /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/libompd/test/openmp_examples/Output/example_2.c.tmp.compile
# .---command stdout------------
# | In file included from /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/openmp/libompd/test/openmp_examples/example_2.c:4:
# | /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/openmp/libompd/test/openmp_examples/../ompt_plugin.h:130:34: error: static declaration of 'ompt_start_tool' follows non-static declaration
# |   130 | static ompt_start_tool_result_t *ompt_start_tool(unsigned int omp_version,
# |       |                                  ^
# | /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/lib/clang/19/include/omp-tools.h:1416:27: note: previous declaration is here
# |  1416 | ompt_start_tool_result_t *ompt_start_tool(unsigned int omp_version,
# |       |                           ^
# | 1 error generated.
# `-----------------------------

--

********************

@llvm-ci
Copy link
Collaborator

llvm-ci commented Jul 3, 2024

LLVM Buildbot has detected a new failure on builder openmp-s390x-linux running on systemz-1 while building openmp at step 6 "test-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/540

Here is the relevant piece of the build log for the reference:

Step 6 (test-openmp) failure: test (failure)
******************** TEST 'ompd-test :: openmp_examples/example_2.c' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/./bin/clang -fopenmp -g -gdwarf-4 /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.src/openmp/libompd/test/openmp_examples/example_2.c -o /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/runtimes/runtimes-bins/openmp/libompd/test/openmp_examples/Output/example_2.c.tmp  -I /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.src/openmp/libompd/test -I /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/runtimes/runtimes-bins/openmp/runtime/src  -L /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/runtimes/runtimes-bins/openmp/runtime/src 2>&1 | tee /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/runtimes/runtimes-bins/openmp/libompd/test/openmp_examples/Output/example_2.c.tmp.compile
# executed command: /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/./bin/clang -fopenmp -g -gdwarf-4 /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.src/openmp/libompd/test/openmp_examples/example_2.c -o /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/runtimes/runtimes-bins/openmp/libompd/test/openmp_examples/Output/example_2.c.tmp -I /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.src/openmp/libompd/test -I /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -L /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/runtimes/runtimes-bins/openmp/runtime/src
# note: command had no output on stdout or stderr
# error: command failed with exit status: 1
# executed command: tee /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/runtimes/runtimes-bins/openmp/libompd/test/openmp_examples/Output/example_2.c.tmp.compile
# .---command stdout------------
# | In file included from /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.src/openmp/libompd/test/openmp_examples/example_2.c:4:
# | /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.src/openmp/libompd/test/openmp_examples/../ompt_plugin.h:130:34: error: static declaration of 'ompt_start_tool' follows non-static declaration
# |   130 | static ompt_start_tool_result_t *ompt_start_tool(unsigned int omp_version,
# |       |                                  ^
# | /home/uweigand/sandbox/buildbot/openmp-s390x-linux/llvm.build/lib/clang/19/include/omp-tools.h:1416:27: note: previous declaration is here
# |  1416 | ompt_start_tool_result_t *ompt_start_tool(unsigned int omp_version,
# |       |                           ^
# | 1 error generated.
# `-----------------------------

--

********************

@hansangbae
Copy link
Contributor Author

Looks like we need a fix in the libompd test.
PR is available at #97616.

kbluck pushed a commit to kbluck/llvm-project that referenced this pull request Jul 6, 2024
@hansangbae @kbluck
[OpenMP] Add ompt_start_tool declaration in omp-tools.h (llvm#97099)
6e0b69d 
The function ompt_start_tool is a globally-visible C function according
to the specification.
@hansangbae hansangbae deleted the 20240628-ompt-start-tool branch July 16, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprotze jprotze jprotze approved these changes

@TerryLWilmarth TerryLWilmarth Awaiting requested review from TerryLWilmarth

@jpeyton52 jpeyton52 Awaiting requested review from jpeyton52

@nawrinsu nawrinsu Awaiting requested review from nawrinsu

Assignees
No one assigned
Labels
openmp:libomp OpenMP host runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hansangbae @llvm-ci @jprotze