Skip to content

[libc]: fix missing linux/error-number-macros.h #97101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

izaakschroeder
Copy link
Contributor

The headers installation previously missed platform-specific number macros, and this fixes that. From discussion on LLVM discord with michaelrj – ccing @michaelrj-google who hopefully is the same person 😅

N.B. I have tested this manually in my Linux Dockerfile and it appears to do the right thing; I haven't done much more than that.

The headers installation previously missed platform-specific number macros, and this fixes that.
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the libc label Jun 28, 2024
@llvmbot
Copy link
Member

llvmbot commented Jun 28, 2024

@llvm/pr-subscribers-libc

Author: Izaak Schroeder (izaakschroeder)

Changes

The headers installation previously missed platform-specific number macros, and this fixes that. From discussion on LLVM discord with michaelrj – ccing @michaelrj-google who hopefully is the same person 😅

N.B. I have tested this manually in my Linux Dockerfile and it appears to do the right thing; I haven't done much more than that.


Full diff: https://github.com/llvm/llvm-project/pull/97101.diff

1 Files Affected:

  • (modified) libc/include/CMakeLists.txt (+1)
diff --git a/libc/include/CMakeLists.txt b/libc/include/CMakeLists.txt
index 2ce8423ae4d9b..3ab7817d8568b 100644
--- a/libc/include/CMakeLists.txt
+++ b/libc/include/CMakeLists.txt
@@ -223,6 +223,7 @@ add_gen_header(
   GEN_HDR errno.h
   DEPENDS
     .llvm-libc-macros.generic_error_number_macros
+    .llvm-libc-macros.error_number_macros
 )
 
 add_gen_header(

Copy link
Contributor

@jhuber6 jhuber6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file only has entries for __linux__ but every target has it, so no reason not to put it in the dependencies. Thanks.

Copy link
Contributor

@michaelrj-google michaelrj-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, and yes you found the right person :)

@jhuber6 jhuber6 merged commit 74852bf into llvm:main Jun 28, 2024
6 of 7 checks passed
Copy link

@izaakschroeder Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

@izaakschroeder izaakschroeder mentioned this pull request Jun 30, 2024
39 tasks
lravenclaw pushed a commit to lravenclaw/llvm-project that referenced this pull request Jul 3, 2024
The headers installation previously missed platform-specific number
macros, and this fixes that. From discussion on LLVM discord with
`michaelrj` – ccing @michaelrj-google who hopefully is the same person 😅

N.B. I have tested this manually in my Linux Dockerfile and it appears
to do the right thing; I haven't done much more than that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants