-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[libc]: fix missing linux/error-number-macros.h
#97101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The headers installation previously missed platform-specific number macros, and this fixes that.
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
@llvm/pr-subscribers-libc Author: Izaak Schroeder (izaakschroeder) ChangesThe headers installation previously missed platform-specific number macros, and this fixes that. From discussion on LLVM discord with N.B. I have tested this manually in my Linux Dockerfile and it appears to do the right thing; I haven't done much more than that. Full diff: https://github.com/llvm/llvm-project/pull/97101.diff 1 Files Affected:
diff --git a/libc/include/CMakeLists.txt b/libc/include/CMakeLists.txt
index 2ce8423ae4d9b..3ab7817d8568b 100644
--- a/libc/include/CMakeLists.txt
+++ b/libc/include/CMakeLists.txt
@@ -223,6 +223,7 @@ add_gen_header(
GEN_HDR errno.h
DEPENDS
.llvm-libc-macros.generic_error_number_macros
+ .llvm-libc-macros.error_number_macros
)
add_gen_header(
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file only has entries for __linux__
but every target has it, so no reason not to put it in the dependencies. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch, and yes you found the right person :)
@izaakschroeder Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested Please check whether problems have been caused by your change specifically, as How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
The headers installation previously missed platform-specific number macros, and this fixes that. From discussion on LLVM discord with `michaelrj` – ccing @michaelrj-google who hopefully is the same person 😅 N.B. I have tested this manually in my Linux Dockerfile and it appears to do the right thing; I haven't done much more than that.
The headers installation previously missed platform-specific number macros, and this fixes that. From discussion on LLVM discord with
michaelrj
– ccing @michaelrj-google who hopefully is the same person 😅N.B. I have tested this manually in my Linux Dockerfile and it appears to do the right thing; I haven't done much more than that.