Skip to content

[libc][math][c23] Temporarily disable f16div{l,f128} on AArch64 #97182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

overmighty
Copy link
Member

Due to Clang 11 backend error ("Unsupported library call operation!").

See Buildbot failures:

@llvmbot llvmbot added the libc label Jun 29, 2024
@llvmbot
Copy link
Member

llvmbot commented Jun 29, 2024

@llvm/pr-subscribers-libc

Author: OverMighty (overmighty)

Changes

Due to Clang 11 backend error ("Unsupported library call operation!").

See Buildbot failures:


Full diff: https://github.com/llvm/llvm-project/pull/97182.diff

1 Files Affected:

  • (modified) libc/config/linux/aarch64/entrypoints.txt (-8)
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 579d720ebeded..8a26536cea9a0 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -509,7 +509,6 @@ if(LIBC_TYPES_HAS_FLOAT16)
     libc.src.math.copysignf16
     libc.src.math.f16div
     libc.src.math.f16divf
-    libc.src.math.f16divl
     libc.src.math.f16fmaf
     libc.src.math.f16sqrtf
     libc.src.math.fabsf16
@@ -562,13 +561,6 @@ if(LIBC_TYPES_HAS_FLOAT16)
     libc.src.math.ufromfpf16
     libc.src.math.ufromfpxf16
   )
-
-  if(LIBC_TYPES_HAS_FLOAT128)
-    list(APPEND TARGET_LIBM_ENTRYPOINTS
-      # math.h C23 mixed _Float16 and _Float128 entrypoints
-      libc.src.math.f16divf128
-    )
-  endif()
 endif()
 
 if(LIBC_TYPES_HAS_FLOAT128)

@lntue lntue merged commit 2a6e32e into llvm:main Jun 29, 2024
6 of 8 checks passed
lravenclaw pushed a commit to lravenclaw/llvm-project that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants