Skip to content

[llvm][AArch64] Drop unused&redundant field in the TargetParserTest. NFC #97367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 3, 2024

Conversation

jroelofs
Copy link
Contributor

@jroelofs jroelofs commented Jul 2, 2024

There were a couple of cases where this field was just plain wrong because we weren't actually testing against it. Instead, drop the CPUAttr field on AArch64 tests.

jroelofs added 3 commits July 1, 2024 14:30
There were a couple of cases where this field was just plain wrong because we
weren't actually testing against it.  Instead, drop the CPUAttr field on
AArch64 tests.
@jroelofs jroelofs requested a review from tmatheson-arm July 2, 2024 00:03
Copy link

github-actions bot commented Jul 2, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

@jroelofs jroelofs merged commit 9667e60 into llvm:main Jul 3, 2024
5 of 6 checks passed
@jroelofs jroelofs deleted the jroelofs/ignore-aarch64-cpuattr branch July 3, 2024 17:01
kbluck pushed a commit to kbluck/llvm-project that referenced this pull request Jul 6, 2024
…NFC (llvm#97367)

There were a couple of cases where this field was just plain wrong
because we weren't actually testing against it. Instead, drop the
`CPUAttr` field on AArch64 tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants