Skip to content

[OpenMP] Add missing export for dynamic tracking patch. #97419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2024
Merged

[OpenMP] Add missing export for dynamic tracking patch. #97419

merged 1 commit into from
Jul 2, 2024

Conversation

doru1004
Copy link
Contributor

@doru1004 doru1004 commented Jul 2, 2024

Add missing export.

@doru1004 doru1004 requested a review from mstorsjo July 2, 2024 14:02
@llvmbot llvmbot added the openmp:libomp OpenMP host runtime label Jul 2, 2024
@doru1004
Copy link
Contributor Author

doru1004 commented Jul 2, 2024

@mstorsjo this is in response to your comment in: #97065
Please let me know if this fixes the issue you are seeing.

@doru1004 doru1004 requested a review from jhuber6 July 2, 2024 14:06
@doru1004 doru1004 merged commit f056770 into llvm:main Jul 2, 2024
7 checks passed
@mstorsjo
Copy link
Member

mstorsjo commented Jul 2, 2024

@mstorsjo this is in response to your comment in: #97065 Please let me know if this fixes the issue you are seeing.

Thanks! This looks promising, I'll know tomorrow if my next full nightly run passed successfully.

@mstorsjo
Copy link
Member

mstorsjo commented Jul 3, 2024

@mstorsjo this is in response to your comment in: #97065 Please let me know if this fixes the issue you are seeing.

Thanks! This looks promising, I'll know tomorrow if my next full nightly run passed successfully.

Today’s nightly run was successful, so the issue seems to be resolved. Thanks!

lravenclaw pushed a commit to lravenclaw/llvm-project that referenced this pull request Jul 3, 2024
@doru1004 @lravenclaw
[OpenMP] Add missing export for dynamic tracking patch (llvm#97419)
9c6e714 
Add missing export for OpenMP non-offloading builds.
kbluck pushed a commit to kbluck/llvm-project that referenced this pull request Jul 6, 2024
@doru1004 @kbluck
[OpenMP] Add missing export for dynamic tracking patch (llvm#97419)
5421ecf 
Add missing export for OpenMP non-offloading builds.
@dcci dcci mentioned this pull request Jul 8, 2024
Closed
@amd-justchen amd-justchen mentioned this pull request May 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhuber6 jhuber6 jhuber6 approved these changes

@mstorsjo mstorsjo Awaiting requested review from mstorsjo

Assignees
No one assigned
Labels
openmp:libomp OpenMP host runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doru1004 @mstorsjo @jhuber6 @llvmbot