Skip to content

[flang] Fix build problem caused by #96807 #97450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

psteinfeld
Copy link
Contributor

I had erroneously used a bitwise '&' with boolean operands which caused a warning on the ARM build. This change fixes that.

I had erroneously used a bitwise '&' with boolean operands which caused
a warning on the ARM build.  This change fixes that.
@llvmbot llvmbot added flang Flang issues not falling into any other category flang:semantics labels Jul 2, 2024
@llvmbot
Copy link
Member

llvmbot commented Jul 2, 2024

@llvm/pr-subscribers-flang-semantics

Author: Pete Steinfeld (psteinfeld)

Changes

I had erroneously used a bitwise '&' with boolean operands which caused a warning on the ARM build. This change fixes that.


Full diff: https://github.com/llvm/llvm-project/pull/97450.diff

1 Files Affected:

  • (modified) flang/lib/Evaluate/intrinsics-library.cpp (+1-1)
diff --git a/flang/lib/Evaluate/intrinsics-library.cpp b/flang/lib/Evaluate/intrinsics-library.cpp
index c3bd3a501c0c5..65636b9956e78 100644
--- a/flang/lib/Evaluate/intrinsics-library.cpp
+++ b/flang/lib/Evaluate/intrinsics-library.cpp
@@ -807,7 +807,7 @@ static bool VerifyAtan2LikeArguments(
 template <ArgumentVerifierFunc... F>
 static bool CombineVerifiers(
     const std::vector<Expr<SomeType>> &args, FoldingContext &context) {
-  return (... & F(args, context));
+  return (... && F(args, context));
 }
 
 /// Define argument names to be used error messages when the intrinsic have

@psteinfeld psteinfeld merged commit bf5a2a9 into llvm:main Jul 2, 2024
7 of 8 checks passed
@psteinfeld psteinfeld deleted the ps-fix-bitwise-and branch July 2, 2024 17:46
lravenclaw pushed a commit to lravenclaw/llvm-project that referenced this pull request Jul 3, 2024
I had erroneously used a bitwise '&' with boolean operands which caused
a warning on the ARM build. This change fixes that.
kbluck pushed a commit to kbluck/llvm-project that referenced this pull request Jul 6, 2024
I had erroneously used a bitwise '&' with boolean operands which caused
a warning on the ARM build. This change fixes that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:semantics flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants