[msan] Add test cases for vector shadow track origins bug #97611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These test cases demonstrate a bug in MSan (vector shadow is not always converted to scalar before zext) that will shortly be fixed in llvm#96722 The bug is not architecture-specific; we provide both x86 and Arm NEON test cases. Since the test cases will crash the compiler (unless it is a release build), they are marked as UNSUPPORTED. The buggy codepath is nested inside 'if (instrumentWithCalls(ConvertedShadow)'. To keep the test cases small, we set -msan-instrumentation-with-call-threshold=0, though we have observed this bug in the real world with default settings.
vitalybuka
reviewed
Jul 3, 2024
| ; '-msan-instrumentation-with-call-threshold=0' makes it possible to detect the | ||
| ; bug with a short test case. | ||
| ; | ||
| ; '-disable-verify' with a release build is needed to avoid a compiler crash |
There was a problem hiding this comment.
if it's UNSUPPORTED why do we need -disable-verify?
There was a problem hiding this comment.
-disable-verify is necessary to allow autogenerating the assertions in the test.
vitalybuka
approved these changes
Jul 3, 2024
kbluck
pushed a commit
to kbluck/llvm-project
that referenced
this pull request
Jul 6, 2024
These test cases demonstrate a bug in MSan (vector shadow is not always converted to scalar before zext) that will shortly be fixed in llvm#96722 The bug is not architecture-specific; we provide both x86 and Arm NEON test cases. Since the test cases will crash the compiler (unless it is a release build), they are marked as UNSUPPORTED. The buggy codepath is nested inside 'if (instrumentWithCalls(ConvertedShadow)'. To keep the test cases small, we set -msan-instrumentation-with-call-threshold=0, though we have observed this bug in the real world with default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These test cases demonstrate a bug in MSan (vector shadow is not always converted to scalar before zext) that will shortly be fixed in #96722
The bug is not architecture-specific; we provide both x86 and Arm NEON test cases.
Since the test cases will crash the compiler (unless it is a release build), they are marked as UNSUPPORTED.
The buggy codepath is nested inside 'if (instrumentWithCalls(ConvertedShadow)'. To keep the test cases small, we set -msan-instrumentation-with-call-threshold=0, though we have observed this bug in the real world with default settings.