[BOLT] Remove workaround for flushPendingLabels

[MaskRay]

The code emits an empty MCDataFragment to ensure that the labels are
attached to SplitSection. The workaround, due to the removed
flushPendingLabels mechanism (see
7500646), is now unneeded.

[llvmbot]

@llvm/pr-subscribers-bolt

Author: Fangrui Song (MaskRay)

Changes

The code emits an empty MCDataFragment to ensure that the labels are
attached to SplitSection. The workaround, due to the removed
flushPendingLabels mechanism (see
7500646), is now unneeded.

---

Full diff: https://github.com/llvm/llvm-project/pull/97632.diff

1 Files Affected:

• (modified) bolt/lib/Core/BinaryContext.cpp (-8)

diff --git a/bolt/lib/Core/BinaryContext.cpp b/bolt/lib/Core/BinaryContext.cpp
index f28a0cd6eb9c6..0a1f1bb9e0d20 100644
--- a/bolt/lib/Core/BinaryContext.cpp
+++ b/bolt/lib/Core/BinaryContext.cpp
@@ -2403,16 +2403,8 @@ BinaryContext::calculateEmittedSize(BinaryFunction &BF, bool FixBranches) {
     Streamer->emitLabel(SplitStartLabel);
     emitFunctionBody(*Streamer, BF, FF, /*EmitCodeOnly=*/true);
     Streamer->emitLabel(SplitEndLabel);
-    // To avoid calling MCObjectStreamer::flushPendingLabels() which is
-    // private
-    Streamer->emitBytes(StringRef(""));
-    Streamer->switchSection(Section);
   }
 
-  // To avoid calling MCObjectStreamer::flushPendingLabels() which is private or
-  // MCStreamer::Finish(), which does more than we want
-  Streamer->emitBytes(StringRef(""));
-
   MCAssembler &Assembler =
       static_cast<MCObjectStreamer *>(Streamer.get())->getAssembler();
   Assembler.layout();

[aaupov]

Testing internally