Skip to content

[llvm][AArch64] Fix a crash with an incorrect asm constraint #98071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2024
Merged

[llvm][AArch64] Fix a crash with an incorrect asm constraint #98071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11481,6 +11481,8 @@ AArch64TargetLowering::getRegForInlineAsmConstraint(
return std::make_pair(0U, &AArch64::ZPRRegClass);
return std::make_pair(0U, nullptr);
}
if (VT == MVT::Other)
break;
uint64_t VTSize = VT.getFixedSizeInBits();
if (VTSize == 16)
return std::make_pair(0U, &AArch64::FPR16RegClass);
Expand Down
23 changes: 23 additions & 0 deletions llvm/test/CodeGen/AArch64/asm-ld1-wrong-constraint.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
; RUN: not llc < %s -o - 2>&1 | FileCheck %s

target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128-Fn32"
target triple = "arm64-apple-macosx"

%struct.uint64x2x4_t = type { [4 x <2 x i64>] }

define i64 @rdar130887714(ptr noundef %0) {
%2 = alloca ptr, align 8
%3 = alloca %struct.uint64x2x4_t, align 16
store ptr %0, ptr %2, align 8
%4 = load ptr, ptr %2, align 8
call void asm sideeffect "ld1 { $0.2d, ${0:T}.2d, ${0:U}.2d, ${0:V}.2d} , [$1]", "*w,r"(ptr elementtype(%struct.uint64x2x4_t) %3, ptr %4) #0, !srcloc !0
; CHECK: error: Don't know how to handle indirect register inputs yet for constraint 'w' at line 250

%5 = getelementptr inbounds %struct.uint64x2x4_t, ptr %3, i32 0, i32 0
%6 = getelementptr inbounds [4 x <2 x i64>], ptr %5, i64 0, i64 0
%7 = load <2 x i64>, ptr %6, align 16
%8 = extractelement <2 x i64> %7, i32 1
ret i64 %8
}

!0 = !{i64 250}
Loading