Skip to content

[flang] Check assignment conformance for derived types #99059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[flang] Check assignment conformance for derived types #99059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions flang/lib/Semantics/expression.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4533,6 +4533,8 @@ std::optional<ProcedureRef> ArgumentAnalyzer::TryDefinedAssignment() {
!OkLogicalIntegerAssignment(lhsType->category(), rhsType->category())) {
SayNoMatch("ASSIGNMENT(=)", true);
}
} else if (!fatalErrors_) {
CheckAssignmentConformance();
}
return std::nullopt;
}
Expand Down
2 changes: 2 additions & 0 deletions flang/test/Semantics/array-constr-values.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,10 @@ subroutine arrayconstructorvalues()
intarray = [integer:: EMPLOYEE (19, "Jack"), 2, 3, 4, 5]

! C7112
!ERROR: Dimension 1 of left-hand side has extent 3, but right-hand side has extent 2
!ERROR: Value in array constructor of type 'INTEGER(4)' could not be converted to the type of the array 'employee'
emparray = (/ EMPLOYEE:: EMPLOYEE(19, "Ganesh"), EMPLOYEE(22, "Omkar"), 19 /)
!ERROR: Dimension 1 of left-hand side has extent 3, but right-hand side has extent 2
!ERROR: Value in array constructor of type 'employeer' could not be converted to the type of the array 'employee'
emparray = (/ EMPLOYEE:: EMPLOYEE(19, "Ganesh"), EMPLOYEE(22, "Ram"),EMPLOYEER("ShriniwasPvtLtd") /)

Expand Down
6 changes: 6 additions & 0 deletions flang/test/Semantics/assign10.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
! RUN: %python %S/test_errors.py %s %flang_fc1
! Shape conformance checks on assignments
program test
type t
integer n
end type
real :: a0, a1a(2), a1b(3), a2a(2,3), a2b(3,2)
type(t) c(10)
a0 = 0. ! ok
!ERROR: No intrinsic or user-defined ASSIGNMENT(=) matches scalar REAL(4) and rank 1 array of REAL(4)
a0 = [0.]
Expand All @@ -20,4 +24,6 @@ program test
a2a(1,:) = a1a
!ERROR: Dimension 1 of left-hand side has extent 2, but right-hand side has extent 3
a2a = a2b
!ERROR: Dimension 1 of left-hand side has extent 10, but right-hand side has extent 0
c(1:10) = c(10:1)
end
Loading