[clang-tools-extra] Fix typos in Modularize.rst #99256
Conversation
…extra/docs/modularize.rst” mainly, fixed “the Clang module mechanism doesn’t support headers the rely on other headers” => “the Clang module mechanism doesn’t support headers that rely on other headers”. [emphasis on “the” versus “that”]
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@llvm/pr-subscribers-clang-tools-extra Author: Abe (Abe149) Changesmainly, fixed “the Clang module mechanism doesn’t support headers the rely on other headers” => “the Clang module mechanism doesn’t support headers that rely on other headers”. [emphasis on “the” versus “that”] Full diff: https://github.com/llvm/llvm-project/pull/99256.diff 1 Files Affected:
diff --git a/clang-tools-extra/docs/modularize.rst b/clang-tools-extra/docs/modularize.rst
index 64ca8c99d4e8e..97fd33b958650 100644
--- a/clang-tools-extra/docs/modularize.rst
+++ b/clang-tools-extra/docs/modularize.rst
@@ -254,8 +254,8 @@ For example, with the same header list from above::
}
Note that headers with dependents will be ignored with a warning, as the
-Clang module mechanism doesn't support headers the rely on other headers
-to be included first.
+Clang module mechanism doesn't support headers that rely on other headers
+being included first.
The module map format defines some keywords which can't be used in module
names. If a header has one of these names, an underscore ('_') will be
|
Endilll
changed the title
|
I took the liberty to rename the PR to something more typical for our repository. I hope you don't mind. |
|
|
|
We don't have to wait for Linux CI to finish to merge this, but private e-mail is an issue. |
I think I fixed it. Please let me know if it`s good now or if I need to make more changes to my GitHub profile. |
|
@Abe149 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested Please check whether problems have been caused by your change specifically, as How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
|
I saw your email in the merge box so I've gone ahead and landed it (I think the workflow that checks for a private email may only be re-run when the changes in the PR are updated). Thanks for the contribution! |
@DavidSpickett: you are welcome, and thanks for merging. |
Summary: mainly, fixed “the Clang module mechanism doesn’t support headers the rely on other headers” => “the Clang module mechanism doesn’t support headers that rely on other headers”. [emphasis on “the” versus “that”] Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250885
mainly, fixed “the Clang module mechanism doesn’t support headers the rely on other headers” => “the Clang module mechanism doesn’t support headers that rely on other headers”. [emphasis on “the” versus “that”]