[AArch64][SME] Make use of Arm Optimised Routines in compiler-rt #99326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of streaming-compatible versions of standard C functions were added to compiler-rt, however there are already optimised versions of most of these in libc which are valid in streaming-SVE mode. This patch replaces the implementations of __arm_sc_mem* with these versions where possible.
kmclaughlin-arm
requested review from
nickdesaulniers,
SamTebbs33,
dtemirbulatov and
sdesmalen-arm
| @@ -571,7 +571,7 @@ set(aarch64_SOURCES | |||
|
|
|||
| if (COMPILER_RT_HAS_AARCH64_SME) | |||
| if (NOT COMPILER_RT_DISABLE_AARCH64_FMV AND COMPILER_RT_HAS_FNO_BUILTIN_FLAG AND (COMPILER_RT_HAS_AUXV OR COMPILER_RT_BAREMETAL_BUILD)) | |||
| list(APPEND aarch64_SOURCES aarch64/sme-abi.S aarch64/sme-abi-init.c aarch64/sme-abi-vg.c aarch64/sme-libc-routines.c) | |||
| list(APPEND aarch64_SOURCES aarch64/sme-abi.S aarch64/sme-libc-mem-routines.S aarch64/sme-abi-init.c aarch64/sme-abi-vg.c aarch64/sme-libc-routines.c ) | |||
There was a problem hiding this comment.
An extra symbol in the line end, just before ")"?
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
) Summary: A number of streaming-compatible versions of standard C functions were added to compiler-rt, however there are already optimised versions of most of these in libc which are valid in streaming-SVE mode. This patch replaces the implementations of __arm_sc_mem* with these versions where possible. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of streaming-compatible versions of standard C functions
were added to compiler-rt, however there are already optimised
versions of most of these in libc which are valid in streaming-SVE
mode. This patch replaces the implementations of __arm_sc_mem* with
these versions where possible.