Skip to content

[SandboxIR][NFC] Add some comments #99359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2024
Merged

[SandboxIR][NFC] Add some comments #99359

merged 1 commit into from
Jul 17, 2024

Conversation

vporpo
Copy link
Contributor

@vporpo vporpo commented Jul 17, 2024

No description provided.

@vporpo vporpo requested review from echristo, tschuett and aeubanks July 17, 2024 17:28
@@ -415,6 +423,7 @@ class Constant : public sandboxir::User {
};

/// The BasicBlock::iterator.
/// It returns a sandboxir::BasicBlock & when derereferenced.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix wording to be consistent with above wording like OperandUseIterator

@vporpo vporpo merged commit ddbf5ea into llvm:main Jul 17, 2024
4 of 6 checks passed
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
Summary: 

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants