Skip to content

[libc++][test] Raise a useful error when no -std=c++NN flag is found to work #99423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2024
Merged

[libc++][test] Raise a useful error when no -std=c++NN flag is found to work #99423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33db30b
Raise a useful error when no -std=c++NN flag is detected
randomnetcat Jul 18, 2024
9b2d218
Fix formatting issues
randomnetcat Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions libcxx/utils/libcxx/test/params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,17 @@ def getStdFlag(cfg, std):
return None


def getDefaultStdValue(cfg):
viable = [s for s in reversed(_allStandards) if getStdFlag(cfg, s)]

if not viable:
raise RuntimeError(
"Unable to successfully detect the presence of any -std=c++NN flag. This likely indicates an issue with your compiler."
)

return viable[0]


def getSpeedOptimizationFlag(cfg):
if _isClang(cfg) or _isAppleClang(cfg) or _isGCC(cfg):
return "-O3"
Expand Down Expand Up @@ -170,9 +181,7 @@ def getSuitableClangTidy(cfg):
choices=_allStandards,
type=str,
help="The version of the standard to compile the test suite with.",
default=lambda cfg: next(
s for s in reversed(_allStandards) if getStdFlag(cfg, s)
),
default=lambda cfg: getDefaultStdValue(cfg),
actions=lambda std: [
AddFeature(std),
AddSubstitution("%{cxx_std}", re.sub(r"\+", "x", std)),
Expand Down
Loading