Skip to content

libclc: fix convert with half #99481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2024
Merged

libclc: fix convert with half #99481

merged 1 commit into from
Jul 18, 2024

Conversation

rjodinchr
Copy link
Contributor

Fix following update of libclc introducing more fp16 support: 7e6a739

@rjodinchr
libclc: fix convert with half
63f5f5a 
Fix following update of libclc introducing more fp16 support:
llvm@7e6a739
@rjodinchr
Copy link
Contributor Author

@frasercrmck could you please review? thanks

@rjodinchr rjodinchr mentioned this pull request Jul 18, 2024
Merged
@joker-eph joker-eph merged commit d9cb65f into llvm:main Jul 18, 2024
6 of 7 checks passed
@joker-eph
Copy link
Collaborator

joker-eph commented Jul 18, 2024 •
edited
Loading

Thanks for the quick fix!
In general, if you feel like you need a review on a fix, you need to revert the original PR immediately to unbreak the CI and re-land a new PR with the fix: the priority is to get bots back green.
In many cases, you can rely on post-commit review (land the fix PR speculatively to unbreak the CI and follow-up with the reviewers).

@rjodinchr
Copy link
Contributor Author

Thanks for the quick fix! In general, if you feel like you need a review on a fix, you need to revert the original PR immediately to unbreak the CI and re-land a new PR with the fix: the priority is to get bots back green. In many cases, you can rely on post-commit review (land the fix PR speculatively to unbreak the CI and follow-up with the reviewers).

Thank you for the information.
I am not able to submit the fix myself, that's why I asked for a review to submit it. Is there a process to get the permission to submit this kind of fix myself?

@rjodinchr rjodinchr deleted the pr/fix-libclc branch July 18, 2024 13:43
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
@rjodinchr @yuxuanchen1997
libclc: fix convert with half (#99481)
fa9746e 
Summary:
Fix following update of libclc introducing more fp16 support:
7e6a739

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60250807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frasercrmck frasercrmck frasercrmck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjodinchr @joker-eph @frasercrmck