Skip to content

[libc++] Refactor buildkite-pipeline.yml #99483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Jul 18, 2024

This patch removes unused stuff from the Buildkite pipeline definition.

This patch removes unused stuff from the Buildkite pipeline definition.
@ldionne ldionne requested a review from a team as a code owner July 18, 2024 12:33
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jul 18, 2024
@llvmbot
Copy link
Member

llvmbot commented Jul 18, 2024

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

This patch removes unused stuff from the Buildkite pipeline definition.


Full diff: https://github.com/llvm/llvm-project/pull/99483.diff

1 Files Affected:

  • (modified) libcxx/utils/ci/buildkite-pipeline.yml (-19)
diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml
index 71d211bfc287d..0a81268cbe7a1 100644
--- a/libcxx/utils/ci/buildkite-pipeline.yml
+++ b/libcxx/utils/ci/buildkite-pipeline.yml
@@ -17,11 +17,6 @@
 # goal being to reduce the load on testers when a commit is known to fail.
 #
 
-# The Linux CI runners use the nightly ToT build provided by the Docker image.
-# (Note the image isn't updated daily.) The LLVM_HEAD_VERSION contains that
-# version number. The Linux CI runners for GCC use the latest stable version.
-# Theses numbers are available in all runners, making it easier to update the
-# version number.
 env:
     # LLVM POST-BRANCH bump version
     # LLVM POST-BRANCH add compiler test for ToT - 1, e.g. "Clang 17"
@@ -41,20 +36,6 @@ definitions:
       - "**/*.abilist"
       - "**/crash_diagnostics/*"
 
-environment_definitions:
-  _common_env: &common_env
-      LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}"
-      CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
-      CC: clang-${LLVM_HEAD_VERSION}
-      CXX: clang++-${LLVM_HEAD_VERSION}
-
-  _absolute_path_clang: &absolute_path_clang
-    # Note modules require and absolute path for clang-scan-deps
-    # https://github.com/llvm/llvm-project/issues/61006
-    CC: /usr/lib/llvm-${LLVM_HEAD_VERSION}/bin/clang
-    CXX: /usr/lib/llvm-${LLVM_HEAD_VERSION}/bin/clang++
-
-
 steps:
 - group: ':mac: Apple'
   steps:

@ldionne ldionne merged commit 2f8c786 into llvm:main Jul 19, 2024
56 checks passed
@ldionne ldionne deleted the review/buildkite-refactor branch July 19, 2024 15:47
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
Summary: This patch removes unused stuff from the Buildkite pipeline definition.

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants