suppresses unused variable warning #99526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-debuginfo Author: Christopher Di Bella (cjdb) ChangesFull diff: https://github.com/llvm/llvm-project/pull/99526.diff 1 Files Affected:
diff --git a/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp b/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
index b9cf36a07846c..3d90c0a2c0de3 100644
--- a/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
+++ b/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
@@ -3362,6 +3362,7 @@ void InstrRefBasedLDV::buildVLocValueMap(
if (BlockLiveIn->Kind == DbgValue::VPHI)
BlockLiveIn->Kind = DbgValue::Def;
auto &[Var, DILoc] = DVMap.lookupDVID(VarID);
+ (void)DILoc;
assert(BlockLiveIn->Properties.DIExpr->getFragmentInfo() ==
Var.getFragment() &&
"Fragment info missing during value prop");
|
slackito
reviewed
Jul 18, 2024
slackito
approved these changes
Jul 18, 2024
dwblaikie
reviewed
Jul 21, 2024
| @@ -3361,7 +3361,7 @@ void InstrRefBasedLDV::buildVLocValueMap( | |||
| continue; | |||
| if (BlockLiveIn->Kind == DbgValue::VPHI) | |||
| BlockLiveIn->Kind = DbgValue::Def; | |||
| auto &[Var, DILoc] = DVMap.lookupDVID(VarID); | |||
| [[maybe_unused]] auto &[Var, DILoc] = DVMap.lookupDVID(VarID); | |||
There was a problem hiding this comment.
FWIW/next time, I'd consider rolling this into the assert, maybe?
assert(BlockLiveIn->Properties.DIExpr->getFragmentInfo() ==
DVMap.lookupDVID(VarID).first.getFragment() &&
...
(so the optimizer doesn't have to deal with the lookup code in nonasserts builds)
(and/or if the named variable helped with readability/was needed for other reasons, maybe using auto &VarID = ...(VarID).first; ? rather than needing to name an extra fully unused variable (DILoc))
|
(Thanks for catching this for me!) |
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250781
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.