[libc][CMake] Set library type of libcMPFRWrapper to STATIC #99527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes linker errors due to hidden symbols when running CMake with -DBUILD_SHARED_LIBS=ON.
|
@llvm/pr-subscribers-libc Author: OverMighty (overmighty) ChangesFixes linker errors due to hidden symbols when running CMake with Full diff: https://github.com/llvm/llvm-project/pull/99527.diff 1 Files Affected:
diff --git a/libc/utils/MPFRWrapper/CMakeLists.txt b/libc/utils/MPFRWrapper/CMakeLists.txt
index e74b02204ed6f..be0415d0956fa 100644
--- a/libc/utils/MPFRWrapper/CMakeLists.txt
+++ b/libc/utils/MPFRWrapper/CMakeLists.txt
@@ -1,5 +1,5 @@
if(LIBC_TESTS_CAN_USE_MPFR)
- add_library(libcMPFRWrapper
+ add_library(libcMPFRWrapper STATIC
MPFRUtils.cpp
MPFRUtils.h
mpfr_inc.h
|
jhuber6
approved these changes
Jul 18, 2024
lntue
approved these changes
Jul 18, 2024
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: Fixes linker errors due to hidden symbols when running CMake with -DBUILD_SHARED_LIBS=ON. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes linker errors due to hidden symbols when running CMake with
-DBUILD_SHARED_LIBS=ON.