[SandboxIR][Tracker] Track Instruction::removeFromParent() #99541
+106
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds the necessary functionality to the Tracker and to the Sandbox IR API functions for tracking calls to removeFromParent().
aeubanks
approved these changes
Jul 18, 2024
| /// The instruction that is about to get removed. | ||
| Instruction *RemovedI = nullptr; | ||
| /// This is either the next instr, or the parent BB if at the end of the BB. | ||
| PointerUnion<Instruction *, BasicBlock *> NextInstrOrBB; |
There was a problem hiding this comment.
maybe a helper typedef and function would be useful if this is used in a lot of IRChangeBases
There was a problem hiding this comment.
Yeah I could do that in a follow-up NFC
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
This patch adds the necessary functionality to the Tracker and to the Sandbox IR API functions for tracking calls to removeFromParent().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the necessary functionality to the Tracker and to the Sandbox IR API functions for tracking calls to removeFromParent().