[mlir][ArmSME] Suppress potential unused warning #99573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building in release mode, the assert will be dropped, making `remove` unused.
wecing
requested review from
banach-space,
dcaballe and
nicolasvasilache
as code owners
|
@llvm/pr-subscribers-mlir-sme Author: Chenguang Wang (wecing) ChangesWhen building in release mode, the assert will be dropped, making Full diff: https://github.com/llvm/llvm-project/pull/99573.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/ArmSME/Transforms/TileAllocation.cpp b/mlir/lib/Dialect/ArmSME/Transforms/TileAllocation.cpp
index 5cac770b03ed1..4648944156951 100644
--- a/mlir/lib/Dialect/ArmSME/Transforms/TileAllocation.cpp
+++ b/mlir/lib/Dialect/ArmSME/Transforms/TileAllocation.cpp
@@ -619,6 +619,7 @@ void allocateTilesToLiveRanges(
// Remove the live range from the active/inactive sets.
if (!activeRanges.remove(rangeToSpill)) {
bool removed = inactiveRanges.remove(rangeToSpill);
+ (void)removed;
assert(removed && "expected a range to be removed!");
}
}
|
|
@llvm/pr-subscribers-mlir Author: Chenguang Wang (wecing) ChangesWhen building in release mode, the assert will be dropped, making Full diff: https://github.com/llvm/llvm-project/pull/99573.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/ArmSME/Transforms/TileAllocation.cpp b/mlir/lib/Dialect/ArmSME/Transforms/TileAllocation.cpp
index 5cac770b03ed1..4648944156951 100644
--- a/mlir/lib/Dialect/ArmSME/Transforms/TileAllocation.cpp
+++ b/mlir/lib/Dialect/ArmSME/Transforms/TileAllocation.cpp
@@ -619,6 +619,7 @@ void allocateTilesToLiveRanges(
// Remove the live range from the active/inactive sets.
if (!activeRanges.remove(rangeToSpill)) {
bool removed = inactiveRanges.remove(rangeToSpill);
+ (void)removed;
assert(removed && "expected a range to be removed!");
}
}
|
dcaballe
approved these changes
Jul 18, 2024
|
whoops, apparently there's 99faa03 as well @kazutakahirata let me remove my change, then |
wecing
added a commit
to wecing/llvm-project
that referenced
this pull request
Jul 18, 2024
This reverts commit 05bce3f. The work was already done in 99faa03.
wecing
added a commit
that referenced
this pull request
Jul 18, 2024
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
When building in release mode, the assert will be dropped, making `remove` unused.
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building in release mode, the assert will be dropped, making
removeunused.